Skip to content

Fix selected request not changing with profile #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Mar 27, 2025

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

When the selected profile changes, the selected request would remain the same. This was because the root component was only checking if the selected recipe changed, not the profile. Easy fix.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

This is clearly fragile. Added tests to make that less so.

QA

How did you test this?

Added unit tests, confirmed manually.

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering enabled auto-merge (rebase) March 27, 2025 14:37
@LucasPickering LucasPickering merged commit c880c3e into master Mar 27, 2025
15 checks passed
@LucasPickering LucasPickering deleted the fix-profile-switch branch March 27, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant