[PoC] Storybook for package scss - vanilla #1277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(it needs a npm link to @lf/icons to work, whcich scares me a llittle)
lucienbertin
added
enhancement
🔨 Technical
|
jenkins auto deploy http://lucca-front.lucca.local/PR-1277 |
|
jenkins auto deploy http://lucca-front.lucca.local/PR-1277 |
|
jenkins auto deploy http://lucca-front.lucca.local/PR-1277 |
|
not the implementation chosen, see #1286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a storybook sandbox at the root of lf repo
doesn't use a js framework (vue, angular, react) for more easier usage
EDIT won't scale - don't merge - see #1283
this PoC was with the approach of one storybook at LF root for all 3 packages . one storybook to rule them all, and in darkness bind them.
But but but that wont work cuz until SBv7 there is no support for multiple frameworks, and the only official solution for mono repos with multiple frameworks is composaition (github issue, sb doc) and the way it works is you have
Nmicro SB portals that you feed into1macro SB portal.so for it to work we will need 1 SB portal for each package (icons, scss, ng)