Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shareable stylelint package for lucca-front. #2745

Draft
wants to merge 41 commits into
base: rc
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
56c8ec8
[Stylelint] Create shareable package for lucca-front.
fbasmaison-lucca Apr 19, 2024
a9f4eab
[Stylelint] Use legacy notation for colors (`rgba` instead of `rgb`).
fbasmaison-lucca Apr 25, 2024
f0a6803
[Stylelint] Update documentation:
fbasmaison-lucca Apr 25, 2024
f2c6b5d
[Stylelint] Add Code owners.
fbasmaison-lucca Apr 25, 2024
0060f68
[Stylelint] Fix a typo.
fbasmaison-lucca Apr 25, 2024
d7615af
chore(stylelint): Update stylelint and its rules.
fbasmaison-lucca Jan 14, 2025
9356089
chore(stylelint): Add SCSS linting in Jenkins.
fbasmaison-lucca Jan 14, 2025
533f9de
ci(jenkins): Add stylelint to dev dependencies for Jenkins.
fbasmaison-lucca Jan 14, 2025
7ee0b08
fix(stylelint): Cancel 'value-keyword-case' to give us more freedom.
fbasmaison-lucca Jan 14, 2025
ca20195
feature(stylelint): Add LF features deprecation linting (hardcoded).
fbasmaison-lucca Jan 14, 2025
18b1ff3
fix(stylelint): scss/load-no-partial-leading-underscore errors.
fbasmaison-lucca Jan 14, 2025
32d7a2a
fix(stylelint): Ignore files used to test.
fbasmaison-lucca Jan 14, 2025
ca382aa
doc(stylelint): Fix documentation to adapt to Jenkins needs.
fbasmaison-lucca Jan 14, 2025
33f2faa
ci(stylelint): Cancel all faulty rules.
fbasmaison-lucca Jan 14, 2025
1da79c4
ci(stylelint): Fix `declaration-block-no-duplicate-properties` errors.
fbasmaison-lucca Jan 14, 2025
e408a4e
ci(stylelint): Fix `scss/no-duplicate-mixins` errors.
fbasmaison-lucca Jan 14, 2025
ac9f956
ci(stylelint): Move `no-duplicate-selectors` rule to project.
fbasmaison-lucca Jan 14, 2025
4ff9cc8
ci(stylelint): Fix `no-irregular-whitespace` errors.
fbasmaison-lucca Jan 14, 2025
1bad499
ci(stylelint): Move `no-descending-specificity` to project.
fbasmaison-lucca Jan 14, 2025
70239ba
ci(stylelint): Fix `scss/no-global-function-names` errors.
fbasmaison-lucca Jan 14, 2025
2099ac3
ci(stylelint): Fix `scss/double-slash-comment-whitespace-inside` errors.
fbasmaison-lucca Jan 14, 2025
057581a
ci(stylelint): Fix `scss/double-slash-comment-empty-line-before` errors.
fbasmaison-lucca Jan 14, 2025
917637c
ci(stylelint): Fix `at-rule-empty-line-before` errors…
fbasmaison-lucca Jan 14, 2025
320f897
ci(stylelint): Move `block-no-empty` to project.
fbasmaison-lucca Jan 14, 2025
de39adc
ci(stylelint): Fix `scss/dollar-variable-empty-line-before` errors…
fbasmaison-lucca Jan 14, 2025
5cde4d2
ci(stylelint): Fix `rule-empty-line-before` errors.
fbasmaison-lucca Jan 14, 2025
9531e00
ci(stylelint): Fix `comment-empty-line-before` errors.
fbasmaison-lucca Jan 14, 2025
e55c2a0
ci(stylelint): Move `scss/at-mixin-argumentless-call-parentheses` to …
fbasmaison-lucca Jan 14, 2025
b5f04d4
ci(stylelint): Move `scss/at-mixin-pattern` to project.
fbasmaison-lucca Jan 14, 2025
f7cf5dd
ci(stylelint): Fix `shorthand-property-no-redundant-values` errors.
fbasmaison-lucca Jan 14, 2025
ddebb07
ci(stylelint): Fix `selector-pseudo-element-colon-notation` errors.
fbasmaison-lucca Jan 14, 2025
f6b68b8
ci(stylelint): Move `scss/at-rule-no-unknown` to project.
fbasmaison-lucca Jan 14, 2025
d3136dd
ci(stylelint): Move `scss/at-rule-conditional-no-parentheses` to proj…
fbasmaison-lucca Jan 14, 2025
f77e735
ci(stylelint): Move `selector-not-notation` to project.
fbasmaison-lucca Jan 14, 2025
b18a8e0
ci(stylelint): Fix `length-zero-no-unit` errors.
fbasmaison-lucca Jan 14, 2025
a7cb139
ci(stylelint): Move `font-family-no-missing-generic-family…` to project.
fbasmaison-lucca Jan 14, 2025
abd53dd
ci(stylelint): Fix `no-empty-source` errors…
fbasmaison-lucca Jan 14, 2025
e333141
ci(stylelint): Move `property-no-vendor-prefix` to project.
fbasmaison-lucca Jan 14, 2025
b9768bb
ci(stylelint): Fix `custom-property-pattern` errors.
fbasmaison-lucca Jan 14, 2025
fd9a9cf
ci(stylelint): Fix `declaration-property-value-disallowed-list` errors.
fbasmaison-lucca Jan 14, 2025
85b47a8
ci(stylelint): Comment rules nullification and trigger errors.
fbasmaison-lucca Jan 14, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .stylelintrc

This file was deleted.

11 changes: 6 additions & 5 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@
Jenkinsfile @LuccaSA/ux-admins
.cd @LuccaSA/ux-admins

#
packages/ng @LuccaSA/ux-admins @LuccaSA/guilde-front
packages/ng/**/*.scss @LuccaSA/ux-devs
packages/icons @LuccaSA/ux-devs
packages/scss @LuccaSA/ux-devs
# Packages
packages/ng @LuccaSA/ux-admins @LuccaSA/guilde-front
packages/ng/**/*.scss @LuccaSA/ux-devs
packages/icons @LuccaSA/ux-devs
packages/scss @LuccaSA/ux-devs
packages/stylelint-config @LuccaSA/ux-devs @LuccaSA/guilde-front

# Storybook
stories @LuccaSA/ux-devs
5 changes: 3 additions & 2 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ node(label: CI.getSelectedLinuxNode(script:this)) {

npmScript(script: 'build')
npmScript(script: 'jenkins-test', skip: isPR)
npmScript(script: 'lint', skip: isPR)
npmScript(script: 'lint:ng', skip: isPR)
npmScript(script: 'lint:scss', skip: isPR)

def shouldDeploy = isPR || isRc || isMaster || isRelease || isPreRelease
loggableStage('Deploy', !shouldDeploy) {
Expand All @@ -57,7 +58,7 @@ node(label: CI.getSelectedLinuxNode(script:this)) {
powershell "Remove-Item \\\\RBX1-SH1-TECH\\lucca-front\\${versionWithoutPrefix}\\storybook -Recurse"
powershell "Copy-Item storybook-static \\\\RBX1-SH1-TECH\\lucca-front\\${versionWithoutPrefix}\\storybook -Recurse"
}

unstash(name: "compodoc-static")
powershell "Remove-Item \\\\RBX1-SH1-TECH\\lucca-front\\${env.BRANCH_NAME}\\compodoc -Recurse"
powershell "Copy-Item compodoc-static \\\\RBX1-SH1-TECH\\lucca-front\\${env.BRANCH_NAME}\\compodoc -Recurse"
Expand Down
Loading