Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minecraft): add get_version & get_versions methods #36

Merged
merged 3 commits into from
May 5, 2022

Conversation

Lucino772
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #36 (6098989) into main (36a1589) will increase coverage by 13.22%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #36       +/-   ##
===========================================
+ Coverage   48.09%   61.32%   +13.22%     
===========================================
  Files          26       27        +1     
  Lines         894      923       +29     
  Branches      117      122        +5     
===========================================
+ Hits          430      566      +136     
+ Misses        453      346      -107     
  Partials       11       11               
Impacted Files Coverage Δ
mojang/minecraft/__init__.py 100.00% <100.00%> (+100.00%) ⬆️
mojang/minecraft/launchermeta.py 100.00% <100.00%> (ø)
mojang/minecraft/proto/query/__init__.py 18.18% <0.00%> (+18.18%) ⬆️
mojang/minecraft/proto/rcon/__init__.py 26.08% <0.00%> (+26.08%) ⬆️
mojang/minecraft/proto/slp/pre_netty/__init__.py 28.00% <0.00%> (+28.00%) ⬆️
mojang/minecraft/proto/slp/post_netty/__init__.py 29.03% <0.00%> (+29.03%) ⬆️
mojang/minecraft/proto/slp/post_netty/types.py 35.29% <0.00%> (+35.29%) ⬆️
mojang/minecraft/proto/rcon/packets.py 37.50% <0.00%> (+37.50%) ⬆️
mojang/minecraft/proto/slp/__init__.py 41.17% <0.00%> (+41.17%) ⬆️
mojang/minecraft/proto/slp/post_netty/packets.py 42.85% <0.00%> (+42.85%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a1589...6098989. Read the comment docs.

@Lucino772 Lucino772 merged commit 8034964 into main May 5, 2022
@Lucino772 Lucino772 deleted the add-mc-versions branch May 5, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant