iOS: Popup is closing when background is touched instead of tapped #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyDucko
approved these changes
Mar 7, 2024
|
@LuckyDucko may I kindly ask if you're going to trigger a new nuget version with this PR anytime soon? We're facing #95 and I wonder if we should implement a workaround or just wait a bit for the new version. |
|
Should be up and ready as version 1.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on iOS, a mopup is closed when a user is touching the background instead of tapping it. This also leads to mopups always closing when the app is swiped into App Switcher mode or similar as the background is touched in the process.
The problem is occurring because the GestureRecognizer in PopUpPageRenderer isn't working anymore (OnTap isn't called). This might also be one of the reason for the changes in the HitTest method in PopUpWindow?
The suggested solution seems to be working but might not be the optimal solution. It attaches the Gesture Recognizer to the View from the ViewController of the PopupPageHandler and uses its Subview in the boundary check.
The solution also seems to fix #95.