Use interfaces instead of implementations #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LuckyDucko please, can you merge and release a new version? Thanks! |
LuckyDucko
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
This completely slipped my mind, @bdovaz thanks for the update.
|
@LuckyDucko Ok ,thanks! Release a new version please, it's blocking us. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LuckyDucko In my case for MVVM I use: https://learn.microsoft.com/en-us/dotnet/communitytoolkit/mvvm/
Using this library forces me to have to implement IPopupViewModel instead of using PopupViewModel directly (because of duplicated INotifyPropertyChanged implementations). This is not a problem, I have looked at how you implement it and I implement it the same way.
The problem comes from:
And that is precisely what I have solved with this PR.