[Android] Fix back button crash + Cleanup #14
Conversation
Fix for #13
| @@ -31,8 +31,6 @@ public static bool SendBackPressed(Action? backPressedHandler = null) | |||
| return true; | |||
| } | |||
|
|
|||
| backPressedHandler?.Invoke(); | |||
There was a problem hiding this comment.
Shouldn't backPressedHandler parameter be removed then, if it's never used? Why did we need it in the first place?
There was a problem hiding this comment.
And this is why i made a PR ahaha.
So as far as im aware, if i keep that invoke in it makes an endless loop which crashes the system.
I think the original intention is to provide extra functionality on top.
The apphostbuilder area seems to be the only place this is registered, so perhaps we instead need to move that custom functionality to there somehow?
I'm on mobile, but i'll give this another shakedown, i need to learn more about apphostbuilder instead of just throwing everything at it and seeing what sticks
There was a problem hiding this comment.
If backPressedHandler is not passed, backPressedHandler?.Invoke(); won't do anything, right? So the problem might be in the value this is passed in backPressedHandler, and not in the parameter itself.
Added TestPage extra Fixed BackHandler Bug.
LuckyDucko
changed the title
Fix for #13
This was causing a loop to call itself, as through AppHostBuilderExtensions this seems to get called, atleast thats what i believe is going on.
Removing this line seems to fix all the issues.