Skip to content

ProjectTo does not load expanded child collections. #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2020
Merged

ProjectTo does not load expanded child collections. #3379

merged 2 commits into from
Apr 29, 2020

Conversation

BlaiseD
Copy link
Contributor

@BlaiseD BlaiseD commented Apr 17, 2020 •
edited by lbargaoanu
Loading

Fixes #3380.

@BlaiseD BlaiseD mentioned this pull request Apr 17, 2020
Closed
@BlaiseD BlaiseD requested a review from lbargaoanu April 17, 2020 10:42
@lbargaoanu
Copy link
Contributor

Please undo the test change and add a new minimal test.

@lbargaoanu lbargaoanu added this to the v.next milestone Apr 17, 2020
@BlaiseD
Copy link
Contributor Author

BlaiseD commented Apr 17, 2020

ok - will do. I thought about that but it looked as though that was the purpose of the current test.

@lbargaoanu
Copy link
Contributor

Of course you can copy the existing one if it's close enough :)

@BlaiseD
Copy link
Contributor Author

BlaiseD commented Apr 18, 2020

New test added @lbargaoanu

lbargaoanu
lbargaoanu approved these changes Apr 18, 2020
View reviewed changes
Copy link
Contributor

@lbargaoanu lbargaoanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BlaiseD
Copy link
Contributor Author

BlaiseD commented Apr 18, 2020

Thanks for reviewing.

@lbargaoanu lbargaoanu changed the title Fix for: ProjectTo does not load expanded child collections. ProjectTo does not load expanded child collections. Apr 21, 2020
@lbargaoanu lbargaoanu mentioned this pull request Apr 29, 2020
Merged
@jbogard jbogard merged commit 48989cd into LuckyPennySoftware:master Apr 29, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lbargaoanu lbargaoanu lbargaoanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jbogard jbogard

Labels

Improvement

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

ProjectTo child collections explicit expansion.

3 participants

@BlaiseD @lbargaoanu @jbogard