Skip to content

Default implementation for GetSubQueryMarker #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Jun 16, 2022
Merged

Default implementation for GetSubQueryMarker #3920

merged 42 commits into from
Jun 16, 2022

Conversation

lbargaoanu
Copy link
Contributor

Fixes #3919.

@lbargaoanu lbargaoanu added this to the 11.0.2 milestone Mar 2, 2022
@lbargaoanu lbargaoanu changed the title Default implementation for GetSubqueryMarker Default implementation for GetSubQueryMarker Mar 6, 2022
lbargaoanu
lbargaoanu commented Mar 8, 2022
View reviewed changes
@lbargaoanu lbargaoanu force-pushed the ProjectTo_NRE branch 2 times, most recently from f3594bb to a025dd5 Compare March 22, 2022 13:25
@jbogard
Copy link
Contributor

jbogard commented Apr 6, 2022

This ready to merge? Go ahead whenever

@lbargaoanu
Copy link
Contributor Author

lbargaoanu commented Apr 6, 2022 •
edited
Loading

It's ready, but I was thinking we would release another patch for 11. #3895 is a binary breaking change. Granted, a small one, but breaking nevertheless :)
I'd say let's revert that, release a patch for 11, merge it again and bump the major.

@lbargaoanu lbargaoanu force-pushed the ProjectTo_NRE branch 9 times, most recently from dbeb1a6 to 4c6465b Compare May 20, 2022 06:30
@lbargaoanu lbargaoanu force-pushed the ProjectTo_NRE branch 4 times, most recently from 2917e0e to 478fa21 Compare June 12, 2022 05:07
lbargaoanu
lbargaoanu commented Jun 12, 2022
View reviewed changes
@lbargaoanu
Copy link
Contributor Author

@jbogard I think we can merge this (I cannot do it myself even when approved).

@jbogard jbogard merged commit 9498221 into master Jun 16, 2022
@lbargaoanu lbargaoanu deleted the ProjectTo_NRE branch June 16, 2022 18:55
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jbogard jbogard jbogard approved these changes

Assignees

No one assigned

Labels

Bug Improvement Internal refactoring

Projects

None yet

Milestone

12.0.0

Development

Successfully merging this pull request may close these issues.

ProjectTo NullReferenceException

3 participants

@lbargaoanu @jbogard @fiseni