Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transitive conversion to Open API 3.0 via Swagger 2.0 #139

Merged
merged 3 commits into from
Nov 1, 2017

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Oct 30, 2017

@MikeRalphson FYI - pretty simple change, but lmk if you have concerns/suggestions. Otherwise I'll merge tomorrow.

Once this is in, I'll update the web demo (#138)

@MikeRalphson
Copy link
Contributor

LGTM! Very neat and it's nice to have an extensible pipeline. I've just released v2.10.0 of swagger2openapi, it'd be great if you could update the dependency and check there's no errors - whether any changes to the test output look ok.

@MikeRalphson
Copy link
Contributor

apib2swagger has also recently released v1.0.0

@rbren
Copy link
Collaborator Author

rbren commented Oct 31, 2017

Managed to update apib2swagger, but I'm having trouble with swagger2openapi@2.10.0. It seems there's some syntax in reftools that's tripping up browserify...I tried webpack as well but hit the same issue. Did you update reftools in the latest release?

@MikeRalphson
Copy link
Contributor

MikeRalphson commented Oct 31, 2017

Yes, 2.10.0 is the first to use reftools. Any idea what is upsetting browserify? I think webpack 3 runs OK over it, but will check.

Update: have tested the three routines that should be used from reftools in requirebin (which uses browserify) and they work ok.

@MikeRalphson
Copy link
Contributor

Don't let it hold up your PR if you want to pin to 2.9.x for now.

@MikeRalphson
Copy link
Contributor

Will have a look at the diff.

@MikeRalphson
Copy link
Contributor

MikeRalphson commented Oct 31, 2017

Ok swagger2openapi v2.10.1 v2.10.2 uses reftools 0.0.10 which bundles ok using wzrd.in - the problem appears to have been the main in package.json pointing to a non-existent file. Can you retry with this version?

@rbren
Copy link
Collaborator Author

rbren commented Nov 1, 2017

Unfortunately still hitting the same problem. For some reason babel isn't replacing let with var and it's getting tripped up on these lines:

function shallowClone(obj) {
    let result = {};
    for (let p in obj) {
        if (obj.hasOwnProperty(p)) {
            result[p] = obj[p];
        }
    }
    return result;
}

It must be something wrong with the babel configuration. I'm going to merge this in with swagger2openapi@2.9.0, but will try and mess with babel once that's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants