Test and update the Observer.py code
#212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ----- * Add tests for the `Observer.py` code, bringing the file up to 100% code coverage. * Add type annotations to the Observer code. Changed ------- * Use the mutex lock as a context manager. Previous behavior was to call `.acquire()` and `.release()`. * Use `.copy()` instead of `[:]` syntax to make a copy of the observer list. * Set `.changed` directly in `.notifyObservers()`. Previous behavior was to call `.clearChanged()`. This resulted in multiple unnecessary functions calls due to the synchronization decorator and RLock re-acquisition. * Use `super().__init__()` syntax.
kurtmckee
force-pushed
the
test-observer
branch
from
ce5d50c to
e0f2060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Observer.pycode, bringing the file up to 100% code coverage.Changed
Use the mutex lock as a context manager.
Previous behavior was to call
.acquire()and.release().Use
.copy()instead of[:]syntax to make a copy of the observer list.Set
.changeddirectly in.notifyObservers().Previous behavior was to call
.clearChanged(). This resulted in multiple unnecessary functions calls due to the synchronization decorator and RLock re-acquisition.Use
super().__init__()syntax.