This repository has been archived by the owner on Oct 25, 2022. It is now read-only.
Replace all occurrences when replacing, not just the first #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luismahou
added a commit
that referenced
this pull request
May 9, 2013
Replace all occurrences when replacing, not just the first
|
Thanks for your contribution. Please allow me a few days to deploy it to npm. Cheers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using grunt-hashres to hash our image resources, in addition to JS and CSS. Since the same image can be used multiple times in a CSS file, we uncovered a bug where hashres only replaces the first occurrence. This pull request fixes it to replace all.