Refer to trait methods by their fully qualified names #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that whatever the context the macro is used in, no method conflicts will happen One particular nasty case that was allowed is having `std::fmt::Debug` imported
|
Thank you for the contribution, I didn't know that was a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that whatever the context the macro is used in, no method conflicts will happen
One particular nasty case that was allowed is having
std::fmt::Debugimported.I've added a "test" for this. IMO it should really be a compiletest done with something like
trybuild, but I think that setting it up is out-of-scope for this PRI've also applied
cargo fmtin a separate commit. My IDE keeps doing that to ensure that the code is always properly formatted, let me know if that's a problem