v0.1.0

dist/v-accordion.css

@@ -1,6 +1,6 @@
 /**
  * vAccordion - AngularJS multi-level accordion component
- * @version v0.0.4
+ * @version v0.1.0
  * @link http://lukaszwatroba.github.io/v-accordion
  * @author Łukasz Wątroba <l@lukaszwatroba.com>
  * @license MIT License, http://www.opensource.org/licenses/MIT
@@ -9,6 +9,7 @@
 /***************************************
  Accordion
  ***************************************/
+/* Settings */
 /**
  * Example HTML:
  *

dist/v-accordion.js

@@ -1,6 +1,6 @@
 /**
  * vAccordion - AngularJS multi-level accordion component
- * @version v0.0.4
+ * @version v0.1.0
  * @link http://lukaszwatroba.github.io/v-accordion
  * @author Łukasz Wątroba <l@lukaszwatroba.com>
  * @license MIT License, http://www.opensource.org/licenses/MIT
@@ -65,18 +65,18 @@ function vAccordionDirective (accordionConfig) {
  function checkCustomControlAPIMethods () {
  angular.forEach(protectedApiMethods, function (iteratedMethodName) {
  if (scope.control[iteratedMethodName]) {
- throw new Error(iteratedMethodName + ' method can not be overwritten');
+ throw new Error('The `' + iteratedMethodName + '` method can not be overwritten');
  }
  });
  }
 
  function checkCustomControlCallbacks () {
  if (!angular.isFunction( scope.control.onExpand )) {
- throw new Error('onExpand callback must be a function');
+ throw new Error('The `onExpand` callback must be a function');
  }
 
  if (!angular.isFunction( scope.control.onCollapse )) {
- throw new Error('onCollapse callback must be a function');
+ throw new Error('The `onCollapse` callback must be a function');
  }
  }
 
@@ -142,7 +142,7 @@ function AccordionDirectiveController ($scope) {
  ctrl.addPane = function (pane) {
  if (!$scope.allowMultiple) {
  if (hasExpandedPane() && pane.isExpanded) {
- throw new Error('allow-multiple attribute is not set');
+ throw new Error('The `allow-multiple` attribute is not set');
  } 
  }
 
@@ -201,7 +201,7 @@ function AccordionDirectiveController ($scope) {
  ctrl.expand(iteratedPane);
  });
  } else {
- throw new Error('allow-multiple attribute is not set');
+ throw new Error('The `allow-multiple` attribute can\'t be found');
  }
  };
 
@@ -323,11 +323,11 @@ function vPaneDirective ($timeout, $animate, accordionConfig) {
  paneContentNative = iElement[0].querySelector('.' + accordionConfig.classes.paneContent);
 
  if (!paneHeaderNative) {
- throw new Error('v-pane-header not found');
+ throw new Error('The `v-pane-header` directive can\'t be found');
  }
 
  if (!paneContentNative) {
- throw new Error('v-pane-content not found');
+ throw new Error('The `v-pane-content` directive can\'t be found');
  }
 
  var paneInnerNative = paneContentNative.querySelector('div');

package.json

@@ -1,7 +1,7 @@
 {
  "name": "v-accordion",
  "description": "vAccordion - AngularJS multi-level accordion component",
- "version": "0.0.4",
+ "version": "0.1.0",
  "author": "Łukasz Wątroba <l@lukaszwatroba.com>",
  "license": "MIT",
  "keywords": [

src/vAccordion/directives/v-accordion.js

@@ -30,18 +30,18 @@ function vAccordionDirective (accordionConfig) {
  function checkCustomControlAPIMethods () {
  angular.forEach(protectedApiMethods, function (iteratedMethodName) {
  if (scope.control[iteratedMethodName]) {
- throw new Error(iteratedMethodName + ' method can not be overwritten');
+ throw new Error('The `' + iteratedMethodName + '` method can not be overwritten');
  }
  });
  }
 
  function checkCustomControlCallbacks () {
  if (!angular.isFunction( scope.control.onExpand )) {
- throw new Error('onExpand callback must be a function');
+ throw new Error('The `onExpand` callback must be a function');
  }
 
  if (!angular.isFunction( scope.control.onCollapse )) {
- throw new Error('onCollapse callback must be a function');
+ throw new Error('The `onCollapse` callback must be a function');
  }
  }
 
@@ -107,7 +107,7 @@ function AccordionDirectiveController ($scope) {
  ctrl.addPane = function (pane) {
  if (!$scope.allowMultiple) {
  if (hasExpandedPane() && pane.isExpanded) {
- throw new Error('allow-multiple attribute is not set');
+ throw new Error('The `allow-multiple` attribute is not set');
  } 
  }
 
@@ -166,7 +166,7 @@ function AccordionDirectiveController ($scope) {
  ctrl.expand(iteratedPane);
  });
  } else {
- throw new Error('allow-multiple attribute is not set');
+ throw new Error('The `allow-multiple` attribute can\'t be found');
  }
  };
 

src/vAccordion/directives/v-pane.js

@@ -29,11 +29,11 @@ function vPaneDirective ($timeout, $animate, accordionConfig) {
  paneContentNative = iElement[0].querySelector('.' + accordionConfig.classes.paneContent);
 
  if (!paneHeaderNative) {
- throw new Error('v-pane-header not found');
+ throw new Error('The `v-pane-header` directive can\'t be found');
  }
 
  if (!paneContentNative) {
- throw new Error('v-pane-content not found');
+ throw new Error('The `v-pane-content` directive can\'t be found');
  }
 
  var paneInnerNative = paneContentNative.querySelector('div');

src/vAccordion/styles/v-accordion.scss

@@ -3,6 +3,12 @@
  ***************************************/
 
 
+/* Settings */
+
+$accordion-spacing: 20px;
+$accordion-expand-duration: 0.5s;
+
+
 /**
  * Example HTML:
  *
@@ -15,9 +21,6 @@
  */
 
 
-$accordion-spacing: 20px;
-$accordion-expand-duration: 0.5s;
-
 .Accordion {
  height: 100%;
  width: 100%;

test/unit/vAccordion/directives/v-accordion.spec.js

@@ -43,7 +43,7 @@ describe('v-accordion directive', function () {
 
 
 
- it('should replace v-accordion with div element and add a class', function () {
+ it('should replace `v-accordion` with `div` element and `Accordion` class', function () {
  var template = generateTemplate();
  var accordion = $compile(template)(scope);
 
@@ -66,15 +66,15 @@ describe('v-accordion directive', function () {
  });
 
 
- it('should allow multiple selections even if allow-multiple attribute has no value', function () {
+ it('should allow multiple selections if `allow-multiple` attribute is defined', function () {
  var template = generateTemplate({ allowMultiple: true });
  var accordion = $compile(template)(scope);
 
  expect(accordion.isolateScope().allowMultiple).toBe(true);
  });
 
 
- it('should merge custom control object with internal control', function () {
+ it('should extend custom control object with internal control', function () {
  var template = generateTemplate({ customControl: true });
  var accordion = $compile(template)(scope);
 
@@ -141,7 +141,7 @@ describe('v-accordion directive', function () {
 
 
 
- it('should add pane to array', function () {
+ it('should add new pane object to `panes` array', function () {
  var samplePane = generatePanes(1)[0];
 
  expect(isolateScope.panes.length).toBe(0);
@@ -152,7 +152,7 @@ describe('v-accordion directive', function () {
  });
 
 
- it('should expand pane and call onExpand callback', function () {
+ it('should expand pane and call `onExpand` callback', function () {
  var samplePanes = generatePanes(5);
  var paneToExpandIndex = 0;
  var paneToExpand = samplePanes[paneToExpandIndex];

test/unit/vAccordion/directives/v-pane-content.spec.js

@@ -40,14 +40,14 @@ describe('v-pane-content directive', function () {
 
 
 
- it('should throw an error if is used outside v-pane directive', function () {
+ it('should throw an error if `v-pane` directive controller can\'t be found', function () {
  var template = '<v-pane-content></v-pane-content>';
 
  expect(function () { $compile(template)(scope); }).toThrow();
  });
 
 
- it('should replace v-pane-content with div element and add a class', function () {
+ it('should replace `v-pane-content` with `div` element and add `Pane-content` class', function () {
  var template = generateTemplate();
 
  var accordion = $compile(template)(scope);
@@ -58,7 +58,7 @@ describe('v-pane-content directive', function () {
  });
 
 
- it('should transclude scope and create inner div wrapper', function () {
+ it('should transclude scope and create inner `div` wrapper', function () {
  var message = 'Hello World!';
 
  var template = generateTemplate({ transcludedContent: '{{ message }}' });

test/unit/vAccordion/directives/v-pane-header.spec.js

@@ -41,14 +41,14 @@ describe('v-pane-header directive', function () {
 
 
 
- it('should throw an error if is used outside v-pane directive', function () {
+ it('should throw an error if `v-pane` directive controller can\'t be found', function () {
  var template = '<v-pane-header></v-pane-header>';
 
  expect(function () { $compile(template)(scope); }).toThrow();
  });
 
 
- it('should replace v-pane-header with div accordion and add a class', function () {
+ it('should replace `v-pane-header` with `div` accordion and add `Pane-header` class', function () {
  var template = generateTemplate();
 
  var accordion = $compile(template)(scope);
@@ -59,7 +59,7 @@ describe('v-pane-header directive', function () {
  });
 
 
- it('should transclude scope and create inner div wrapper', function () {
+ it('should transclude scope and create inner `div` wrapper', function () {
  var message = 'Hello World!';
 
  var template = generateTemplate({ transcludedContent: '{{ message }}' });