fix: Pavex will never use private modules in the paths used to refer to methods in the generated server SDK code. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to methods in the generated server SDK code.
|
/ok-to-check sha=376d96b |
Merged
LukeMathWalker
added a commit
that referenced
this pull request
Nov 1, 2024
## 🤖 New release * `pavex`: 0.1.49 -> 0.1.50 * `pavex_bp_schema`: 0.1.49 -> 0.1.50 * `pavex_reflection`: 0.1.49 -> 0.1.50 * `pavex_macros`: 0.1.49 -> 0.1.50 * `persist_if_changed`: 0.1.49 -> 0.1.50 * `pavex_tracing`: 0.1.49 -> 0.1.50 * `pavex_cli`: 0.1.49 -> 0.1.50 * `pavex_cli_deps`: 0.1.49 -> 0.1.50 * `pavex_miette`: 0.1.49 -> 0.1.50 * `pavexc_cli_client`: 0.1.49 -> 0.1.50 * `pavexc`: 0.1.49 -> 0.1.50 * `pavex_cli_client`: 0.1.49 -> 0.1.50 * `pavex_session`: 0.1.49 -> 0.1.50 * `pavex_session_memory_store`: 0.1.49 -> 0.1.50 * `pavexc_cli`: 0.1.49 -> 0.1.50 * `generate_from_path`: 0.1.49 -> 0.1.50 <details><summary><i><b>Changelog</b></i></summary><p> ## `pavex` <blockquote> ## [0.1.50](0.1.49...0.1.50) - 2024-11-01 ### Added - Support lifetime parameters in type aliases ### Fixed - Supply an (empty) instance of `UrlParams` to the root fallback handler, if it needs it. - Associate the correct function item with resolved methods, rather than the parent impl block. - Improve error message - Look for the 'impl' block in the crate that define the type, rather than the trait, when resolving trait methods - Improve error message when we fail to find a method item in the JSON docs - Don't complain about missing constructors when looking at a naked generic input parameter - Bind generic parameters correctly in all instances - Panic eagerly if internal invariants are not upheld when binding generic parameters - Pavex correctly handles type alises with generic parameters that differ from the target type - Pavex will correctly set the name of the defining crate when resolving local type aliases that refer to remote types - Pavex will never use private modules in the paths used to refer to methods in the generated server SDK code. ([#355](#355)) ### Other - Disable workspace hack before a release - Re-enable workspace hack after a release ([#354](#354)) - Punctuation in error messages. - Improve panic message with details about the item we couldn't handle - Display the available constructibles when PAVEX_DEBUG is set and we incur into a 'missing constructor' error - Display the cyclic dependency graph when PAVEX_DEBUG is set - Provide an easy-to-examine representation for the set of constructibles in a given scope tree </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: pavex-releaser[bot] <ci@pavex.dev> Co-authored-by: pavex-releaser[bot] <167640712+pavex-releaser[bot]@users.noreply.github.com> Co-authored-by: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.