Change dwmblocks to use an asynchronous approach to executing blocks #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commands, instead of sleeping and checking in loop if its time to run a command a POSIX interval timer is set. A signal is sent by the kernel on each expiration of the timer thus invoking the signal handler for that block. For blocks with a signal of 0 a thread is spawned instead of delivery of a signal.
|
Also forgot to add that signal dispositions are now set up by |
|
Can't really tell you anything other than "doesn't work" at this point. The program doesn't die, but ceases to update pretty frequently. Haven't looked at the code. |
|
Strange, apart from some missing glyphs on my end everything seems to be working as expected. Regardless, I'll take another look and run some more tests. Thanks for the feedback. |
|
The whole bar freezes. The freeze happens pretty consistently a second or so in if not immediately. Sorry I can't be more helpful. I've tried disabling different modules and it doesn't seem to make a difference. |
…y. In principle this mutex was not needed since both dimensions of the array are known at compile time, it's size does not change while running and updating the output of blocks happens at different indexes which also don't change the size of the array.
|
Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way dwmblocks functions. Instead of sleeping and checking periodically if a blocks needs to be updated a POSIX interval timer is created for each block. On expiry of this timer a either a signal is sent to the process by the kernel that invokes the signal handler for that block or if the block is setup with a signal of 0 a new thread is spawned for the block which executes the command provided to said block.
The main process after setting up each timer simply calls pause() and waits for a delivery of a signal.
These changes should improve performance and reduce CPU usage.
The program now also needs to be linked with
-lrt.