Allow plugins to use PRIVATE memory instead of SHARED on requests #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloMK7
force-pushed
the
privatemapex
branch
from
ec3d296
to
2ae9876
Compare
|
Well, at least setting the .3gx header bit in the plugin works on my end, but how are users expected to set this bit normally? |
|
AFAIK https://github.com/LumaTeam/Luma3DS/pull/2086/files#diff-24fcd400ed63816ed96d0b98cb41be65cb587d12a067401a7b46a89fd95b1b3eR66 if I read it correctly during review (trusting pablo on that as he said he tested it) |
https://gitlab.com/thepixellizeross/3gxtool/-/commit/b666d94e566e3e63e5260cd098bc060c70516470 |
|
Ah, I was looking at the wrong 3gxtool repo, I see now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
svcMapProcessMemoryExsvc so that it takes an extra flags argument. This change was made in a way that shouldn't break existing plugins or applications.MAPEXFLAGS_PRIVATEflag, which maps the specified memory asPRIVATEinstead ofSHARED.PRIVATEmemory instead ofSHAREDwith a flag in the.3gxheader. This allows plugins to use socket and http services without additional hacks.