Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python 3.13 #225

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Add support for python 3.13 #225

merged 5 commits into from
Feb 21, 2025

Conversation

jlaehne
Copy link
Contributor

@jlaehne jlaehne commented Feb 11, 2025

A few sentences and/or a bulleted list to describe and motivate the change:

  • Add support for python 3.13
  • Drop support for python 3.8
  • Test for oldest supported hyperspy version and pin to >=v1.7.3

Progress of the PR

  • Change implemented (can be split into several points),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:lumispy build of this PR (link in github checks),
  • ready for review.
  • Test 3.13 against hs-RnMinor as Python 3.13 hyperspy/hyperspy#3468 is not yet released

@jlaehne jlaehne added this to the v0.3 milestone Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.30%. Comparing base (098b669) to head (39e471b).
Report is 7 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files          12       12           
  Lines         576      576           
=======================================
  Hits          572      572           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaehne jlaehne force-pushed the python313 branch 7 times, most recently from 3f4687c to e559dbf Compare February 11, 2025 10:35
Copy link
Contributor

@ericpre ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth dropping python 3.8 support? It is not supported officially anymore: https://devguide.python.org/versions

@jlaehne
Copy link
Contributor Author

jlaehne commented Feb 11, 2025

Would it be worth dropping python 3.8 support? It is not supported officially anymore: https://devguide.python.org/versions

Valid point, I was wondering how far backwards to still support python versions when still supporting hyperspy 1.7.x

The multiple tests were just temporary for the moment to see which minor version of 1.7 ist still supported.

@jlaehne
Copy link
Contributor Author

jlaehne commented Feb 11, 2025

@ericpre do you have a spontaneous idea why the 3.13 tests give an event trigger failure when a signal/axes object is part of a touple of possible test inputs?

@ericpre
Copy link
Contributor

ericpre commented Feb 12, 2025

Yes, it needs hyperspy/hyperspy#3468 to be released!

@jlaehne jlaehne merged commit b711aa4 into LumiSpy:main Feb 21, 2025
19 checks passed
@jlaehne jlaehne deleted the python313 branch February 21, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants