-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for python 3.13 #225
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 99.30% 99.30%
=======================================
Files 12 12
Lines 576 576
=======================================
Hits 572 572
Misses 4 4 ☔ View full report in Codecov by Sentry. |
3f4687c
to
e559dbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth dropping python 3.8 support? It is not supported officially anymore: https://devguide.python.org/versions
Valid point, I was wondering how far backwards to still support python versions when still supporting hyperspy 1.7.x The multiple tests were just temporary for the moment to see which minor version of 1.7 ist still supported. |
@ericpre do you have a spontaneous idea why the 3.13 tests give an event trigger failure when a signal/axes object is part of a touple of possible test inputs? |
Yes, it needs hyperspy/hyperspy#3468 to be released! |
A few sentences and/or a bulleted list to describe and motivate the change:
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),docs/readthedocs.org:lumispy
build of this PR (link in github checks),