Skip to content

Commit 7f142a9

Browse files
author
Hannah
authored
Merge pull request CesiumGS#6899 from bampakoa/docs
[WIP]: Improve jsdoc tags for tsd-jsdoc integration
2 parents af26c51 + 80a9461 commit 7f142a9

24 files changed

+138
-75
lines changed

Source/Core/BingMapsGeocoderService.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ define([
4444
/**
4545
* The URL endpoint for the Bing geocoder service
4646
* @type {String}
47-
* @memberof {BingMapsGeocoderService.prototype}
47+
* @memberof BingMapsGeocoderService.prototype
4848
* @readonly
4949
*/
5050
url : {
@@ -56,7 +56,7 @@ define([
5656
/**
5757
* The key for the Bing geocoder service
5858
* @type {String}
59-
* @memberof {BingMapsGeocoderService.prototype}
59+
* @memberof BingMapsGeocoderService.prototype
6060
* @readonly
6161
*/
6262
key : {

Source/Core/DoublyLinkedList.js

+3
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ define([
2323
}
2424
});
2525

26+
/**
27+
* @private
28+
*/
2629
function DoublyLinkedListNode(item, previous, next) {
2730
this.item = item;
2831
this.previous = previous;

Source/Core/EarthOrientationParameters.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ define([
136136
* Gets a promise that, when resolved, indicates that the EOP data has been loaded and is
137137
* ready to use.
138138
*
139-
* @returns {Promise.<undefined>} The promise.
139+
* @returns {Promise} The promise.
140140
*
141141
* @see when
142142
*/

Source/Core/Event.js

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ define([
1515
*
1616
* @alias Event
1717
* @constructor
18-
*
1918
* @example
2019
* MyObject.prototype.myListener = function(arg1, arg2) {
2120
* this.myArg1Copy = arg1;

Source/Core/Fullscreen.js

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ define([
2020
* Browser-independent functions for working with the standard fullscreen API.
2121
*
2222
* @exports Fullscreen
23+
* @namespace
2324
*
2425
* @see {@link http://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html|W3C Fullscreen Living Specification}
2526
*/

Source/Core/Iau2006XysData.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ define([
9696
* the Terrestrial Time (TT) time standard.
9797
* @param {Number} stopSecondTT The seconds past noon of the end of the interval to preload, expressed in
9898
* the Terrestrial Time (TT) time standard.
99-
* @returns {Promise.<undefined>} A promise that, when resolved, indicates that the requested interval has been
99+
* @returns {Promise} A promise that, when resolved, indicates that the requested interval has been
100100
* preloaded.
101101
*/
102102
Iau2006XysData.prototype.preload = function(startDayTT, startSecondTT, stopDayTT, stopSecondTT) {

Source/Core/IauOrientationAxes.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ define([
8080
*
8181
* @param {JulianDate} date The date to evaluate the matrix.
8282
* @param {Matrix3} result The object onto which to store the result.
83-
* @returns {Matrix} The modified result parameter or a new instance of the rotation from ICRF to Fixed.
83+
* @returns {Matrix3} The modified result parameter or a new instance of the rotation from ICRF to Fixed.
8484
*/
8585
IauOrientationAxes.prototype.evaluate = function(date, result) {
8686
if (!defined(date)) {

Source/Core/IntersectionTests.js

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ define([
2828
* Functions for computing the intersection between geometries such as rays, planes, triangles, and ellipsoids.
2929
*
3030
* @exports IntersectionTests
31+
* @namespace
3132
*/
3233
var IntersectionTests = {};
3334

Source/Core/MapboxApi.js

+3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ define([
66
defined) {
77
'use strict';
88

9+
/**
10+
* @exports MapboxApi
11+
*/
912
var MapboxApi = {};
1013

1114
/**

Source/Core/OrientedBoundingBox.js

-13
Original file line numberDiff line numberDiff line change
@@ -250,19 +250,6 @@ define([
250250

251251
var scratchOffset = new Cartesian3();
252252
var scratchScale = new Cartesian3();
253-
/**
254-
* Computes an OrientedBoundingBox given extents in the east-north-up space of the tangent plane.
255-
*
256-
* @param {Plane} tangentPlane The tangent place corresponding to east-north-up.
257-
* @param {Number} minimumX Minimum X extent in tangent plane space.
258-
* @param {Number} maximumX Maximum X extent in tangent plane space.
259-
* @param {Number} minimumY Minimum Y extent in tangent plane space.
260-
* @param {Number} maximumY Maximum Y extent in tangent plane space.
261-
* @param {Number} minimumZ Minimum Z extent in tangent plane space.
262-
* @param {Number} maximumZ Maximum Z extent in tangent plane space.
263-
* @param {OrientedBoundingBox} [result] The object onto which to store the result.
264-
* @returns {OrientedBoundingBox} The modified result parameter or a new OrientedBoundingBox instance if one was not provided.
265-
*/
266253
function fromTangentPlaneExtents(tangentPlane, minimumX, maximumX, minimumY, maximumY, minimumZ, maximumZ, result) {
267254
//>>includeStart('debug', pragmas.debug);
268255
if (!defined(minimumX) ||

Source/Core/PeliasGeocoderService.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ define([
4747
/**
4848
* The Resource used to access the Pelias endpoint.
4949
* @type {Resource}
50-
* @memberof {PeliasGeocoderService.prototype}
50+
* @memberof PeliasGeocoderService.prototype
5151
* @readonly
5252
*/
5353
url: {

Source/Core/Request.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,10 @@ define([
1515
*
1616
* @alias Request
1717
* @constructor
18-
*
18+
* @namespace
19+
* @exports Request
1920
* @param {Object} [options] An object with the following properties:
20-
* @param {Boolean} [options.url] The url to request.
21+
* @param {String} [options.url] The url to request.
2122
* @param {Request~RequestCallback} [options.requestFunction] The function that makes the actual data request.
2223
* @param {Request~CancelCallback} [options.cancelFunction] The function that is called when the request is cancelled.
2324
* @param {Request~PriorityCallback} [options.priorityFunction] The function that is called to update the request's priority, which occurs once per frame.

Source/Core/Simon1994PlanetaryPositions.js

+5-13
Original file line numberDiff line numberDiff line change
@@ -333,11 +333,7 @@ define([
333333
var Sl8 = -80 * 1e-7;
334334

335335
var scratchDate = new JulianDate(0, 0.0, TimeStandard.TAI);
336-
/**
337-
* Gets a point describing the motion of the Earth-Moon barycenter according to the equations
338-
* described in section 6.
339-
*/
340-
336+
// Gets a point describing the motion of the Earth-Moon barycenter according to the equations described in section 6.
341337
function computeSimonEarthMoonBarycenter(date, result) {
342338

343339
// t is thousands of years from J2000 TDB
@@ -375,9 +371,7 @@ define([
375371
longitudeOfNode, meanLongitude, result);
376372
}
377373

378-
/**
379-
* Gets a point describing the position of the moon according to the equations described in section 4.
380-
*/
374+
// Gets a point describing the position of the moon according to the equations described in section 4.
381375
function computeSimonMoon(date, result) {
382376
taiToTdb(date, scratchDate);
383377
var x = (scratchDate.dayNumber - epoch.dayNumber) + ((scratchDate.secondsOfDay - epoch.secondsOfDay)/TimeConstants.SECONDS_PER_DAY);
@@ -481,11 +475,9 @@ define([
481475
longitudeOfNode, meanLongitude, result);
482476
}
483477

484-
/**
485-
* Gets a point describing the motion of the Earth. This point uses the Moon point and
486-
* the 1992 mu value (ratio between Moon and Earth masses) in Table 2 of the paper in order
487-
* to determine the position of the Earth relative to the Earth-Moon barycenter.
488-
*/
478+
// Gets a point describing the motion of the Earth. This point uses the Moon point and
479+
// the 1992 mu value (ratio between Moon and Earth masses) in Table 2 of the paper in order
480+
// to determine the position of the Earth relative to the Earth-Moon barycenter.
489481
var moonEarthMassRatio = 0.012300034; // From 1992 mu value in Table 2
490482
var factor = moonEarthMassRatio / (moonEarthMassRatio + 1.0) * -1;
491483
function computeSimonEarth(date, result) {

Source/Core/TimeIntervalCollection.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ define([
462462
* The data property of the input interval is ignored.
463463
*
464464
* @param {TimeInterval} interval The interval to remove.
465-
* @returns <code>true</code> if the interval was removed, <code>false</code> if no part of the interval was in the collection.
465+
* @returns {Boolean} <code>true</code> if the interval was removed, <code>false</code> if no part of the interval was in the collection.
466466
*/
467467
TimeIntervalCollection.prototype.removeInterval = function(interval) {
468468
//>>includeStart('debug', pragmas.debug);

Source/Core/Transforms.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ define([
4848
* Contains functions for transforming positions to various reference frames.
4949
*
5050
* @exports Transforms
51+
* @namespace
5152
*/
5253
var Transforms = {};
5354

@@ -536,7 +537,7 @@ define([
536537
* indicates that the preload has completed.
537538
*
538539
* @param {TimeInterval} timeInterval The interval to preload.
539-
* @returns {Promise.<undefined>} A promise that, when resolved, indicates that the preload has completed
540+
* @returns {Promise} A promise that, when resolved, indicates that the preload has completed
540541
* and evaluation of the transformation between the fixed and ICRF axes will
541542
* no longer return undefined for a time inside the interval.
542543
*

Source/Core/binarySearch.js

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ define([
88
* Finds an item in a sorted array.
99
*
1010
* @exports binarySearch
11-
*
1211
* @param {Array} array The sorted array to search.
1312
* @param {*} itemToFind The item to find in the array.
1413
* @param {binarySearch~Comparator} comparator The function to use to compare the item to

Source/Core/mergeSort.js

-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ define([
5757
* A stable merge sort.
5858
*
5959
* @exports mergeSort
60-
*
6160
* @param {Array} array The array to sort.
6261
* @param {mergeSort~Comparator} comparator The function to use to compare elements in the array.
6362
* @param {*} [userDefinedObject] Any item to pass as the third parameter to <code>comparator</code>.

Source/Core/writeTextToCanvas.js

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ define([
3232
* @returns {Canvas} A new canvas with the given text drawn into it. The dimensions object
3333
* from measureText will also be added to the returned canvas. If text is
3434
* blank, returns undefined.
35+
* @exports writeTextToCanvas
3536
*/
3637
function writeTextToCanvas(text, options) {
3738
//>>includeStart('debug', pragmas.debug);

Source/DataSources/GroundGeometryUpdater.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ define([
4141
/**
4242
* An abstract class for updating ground geometry entities.
4343
* @constructor
44-
*
44+
* @alias GroundGeometryUpdater
4545
* @param {Object} options An object with the following properties:
4646
* @param {Entity} options.entity The entity containing the geometry to be visualized.
4747
* @param {Scene} options.scene The scene where visualization is taking place.

Source/DataSources/KmlTour.js

+4-24
Original file line numberDiff line numberDiff line change
@@ -106,26 +106,15 @@ define([
106106
cancelAllEntries(this._activeEntries);
107107
};
108108

109-
/**
110-
* Stop all activeEntries.
111-
* @param {Array} activeEntries
112-
*/
109+
// Stop all activeEntries.
113110
function cancelAllEntries(activeEntries) {
114111
for(var entry = activeEntries.pop(); entry !== undefined; entry = activeEntries.pop()) {
115112
entry.stop();
116113
}
117114
}
118115

119-
/**
120-
* Play playlist entry.
121-
* This function is called recursevly with playNext
122-
* and iterates over all entries from playlist.
123-
*
124-
* @param {ViewerWidget} viewer Cesium viewer.
125-
* @param {Object} cameraOptions see {@link Camera#flyTo}.
126-
* @param {Function} allDone a function will be called when all entries from playlist
127-
* being played or user call {@link KmlTour#stop}.
128-
*/
116+
// Play playlist entry.
117+
// This function is called recursevly with playNext and iterates over all entries from playlist.
129118
function playEntry(viewer, cameraOptions, allDone) {
130119
var entry = this.playlist[this.playlistIndex];
131120
if (entry) {
@@ -152,16 +141,7 @@ define([
152141
}
153142
}
154143

155-
/**
156-
* Increment playlistIndex and call playEntry
157-
* if terminated isn't true.
158-
*
159-
* @param {ViewerWidget} viewer passed for recursion.
160-
* @param {Object} cameraOptions passed for recursion.
161-
* @param {Function} allDone passed for recursion.
162-
* @param {Boolean} terminated true if active entry was terminated,
163-
* and the whole tour should be terminated.
164-
*/
144+
// Increment playlistIndex and call playEntry if terminated isn't true.
165145
function playNext(viewer, cameraOptions, allDone, terminated) {
166146
var entry = this.playlist[this.playlistIndex];
167147
this.entryEnd.raiseEvent(entry, terminated);

Source/Renderer/CubeMap.js

+3
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ define([
3232
TextureMinificationFilter) {
3333
'use strict';
3434

35+
/**
36+
* @private
37+
*/
3538
function CubeMap(options) {
3639
options = defaultValue(options, defaultValue.EMPTY_OBJECT);
3740

Source/Renderer/Texture.js

+3
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ define([
3636
TextureMinificationFilter) {
3737
'use strict';
3838

39+
/**
40+
* @private
41+
*/
3942
function Texture(options) {
4043
options = defaultValue(options, defaultValue.EMPTY_OBJECT);
4144

0 commit comments

Comments
 (0)