Implement Slide notes #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LumpBloom7
added
enhancement
This is much simpler than calculating how it should look.
Also made counter clockwise circular slide make sense
Sliding sound coming soon
Way cleaner imo
Straights had it bad, and potentially generated a path with end lane difference of 1
Also prevent nodes generating if the segment is larger than 5 chevrons
This avoids the star still being visible even after the note has been judged
NestedHitObjects are now created even before ApplyToDrawableHitObject is executed.
|
Should be good for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Slide notes present in maimai. (Slide fans come wayy later, there is no way to effectively test that rn)
Each segment roughly spans about 5 chevrons, except for last segment which may span from 3-7 chevrons.
Slides are composed of a TAP and a SLIDE comprised of several nodes depending on the length. TAPs are as one would expect, behaving like the normal counterparts.
All slide nodes except the last don't have hitwindows, meaning the player can hit them anytime within the start and endtimes of the hitobject. Each node
ncan only be successfully hit if nodes beforen-1is judged, judged nodes will automatically judge previous nodes. Only the Tail node will consider the timing of the hit, allowing for the "cheesing" maneuver that a lot of maimai maps make use of, while raising the skill ceiling.Note: cup shapes slides are a bitch to implement, so I'll do them in a future pr.