Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

LunarGOO: Correctly handle phis for empty loop exit block #3

Merged
merged 1 commit into from
Jan 11, 2016

Conversation

greg-lunarg
Copy link
Contributor

If empty loop exit block precedes loop merge block for simple conditional
or induction loop, create phi copies before loop begin and right before
loop end. Constant phi copies can be avoided at loop end.

If empty loop exit block precedes loop merge block for simple conditional
or induction loop, create phi copies before loop begin and right before
loop end. Constant phi copies can be avoided at loop end.
@johnkslang
Copy link
Contributor

See #2. This merge request is an expansion of the ad hoc method of handling phi. Given this code is already written, I can review it and merge it in. However, if another special case shows up, I would encourage doing the experiment with the alternative full solution before deciding to further incrementally pursue the ad hoc approach.

johnkslang added a commit that referenced this pull request Jan 11, 2016
LunarGOO: Correctly handle phis for empty loop exit block
@johnkslang johnkslang merged commit 0ab3d3d into master Jan 11, 2016
@johnkslang johnkslang deleted the gsf-mr2 branch March 10, 2016 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants