Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter compiler flags #1243

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Stricter compiler flags #1243

wants to merge 1 commit into from

Conversation

panos-lunarg
Copy link
Contributor

No description provided.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 33638.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3155 running.

andrew-lunarg
andrew-lunarg reviewed Aug 30, 2023
View reviewed changes
CMakeLists.txt Outdated
@@ -44,6 +44,8 @@ set(GFXRECONSTRUCT_PROJECT_VERSION_PATCH 0)

set(GFXRECON_PROJECT_VERSION_SHA1 "unknown-build-source")

SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pedantic -Wall -Wconversion -Wextra -Werror -Wno-unused-parameter -Wno-missing-field-initializers -Wno-sign-conversion")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to be strict for our own internal builds but permissive for user builds so that package maintainers and others on diverse systems and compiler versions have an easy time but we make sure the code is in good shape.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already tasting my own medicine by seeing failures on CI that do not trigger locally, I think that's a good idea

@panos-lunarg panos-lunarg force-pushed the panos_stricter_gcc_flags branch from 65fc235 to 00ee1ed Compare August 30, 2023 13:11
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 33664.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3156 running.

@panos-lunarg panos-lunarg force-pushed the panos_stricter_gcc_flags branch from 00ee1ed to 603019f Compare August 30, 2023 13:37
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 33681.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3157 running.

@panos-lunarg panos-lunarg force-pushed the panos_stricter_gcc_flags branch from 603019f to 9060302 Compare August 30, 2023 14:50
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 33764.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3158 running.

@panos-lunarg panos-lunarg force-pushed the panos_stricter_gcc_flags branch from 9060302 to 7de5440 Compare August 30, 2023 15:03
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 33791.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3160 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3160 failed.

@panos-lunarg panos-lunarg force-pushed the panos_stricter_gcc_flags branch from 7de5440 to 1f5e3a9 Compare August 31, 2023 07:01
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 34361.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3164 running.

@panos-lunarg panos-lunarg force-pushed the panos_stricter_gcc_flags branch from 1f5e3a9 to fb47ac8 Compare August 31, 2023 07:12
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 34374.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3165 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3165 passed.

@panos-lunarg panos-lunarg force-pushed the panos_stricter_gcc_flags branch from fb47ac8 to dec9f5b Compare September 1, 2023 08:28
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 35024.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3168 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3168 failed.

@bradgrantham-lunarg bradgrantham-lunarg added the P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash. label Oct 30, 2023
@fabian-lunarg fabian-lunarg mentioned this pull request Nov 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-lunarg andrew-lunarg andrew-lunarg left review comments

Assignees
No one assigned
Labels
P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panos-lunarg @ci-tester-lunarg @andrew-lunarg @bradgrantham-lunarg