Use reflection to get DXIL library shader exports #1710
Conversation
|
CI gfxreconstruct build queued with queue ID 249564. |
|
CI gfxreconstruct build # 4762 running. |
|
CI gfxreconstruct build # 4762 failed. |
This is failing because it is finding the wrong |
davidd-lunarg
force-pushed
the
davidd-dxil-parsing
branch
from
7ddf34f
to
85b5700
Compare
|
CI gfxreconstruct build queued with queue ID 280092. |
|
CI gfxreconstruct build # 5089 running. |
|
CI gfxreconstruct build # 5089 failed. |
davidd-lunarg
force-pushed
the
davidd-dxil-parsing
branch
from
85b5700
to
af56818
Compare
|
CI gfxreconstruct build queued with queue ID 284685. |
|
CI gfxreconstruct build # 284685 cancelled. |
davidd-lunarg
force-pushed
the
davidd-dxil-parsing
branch
from
af56818
to
876c85c
Compare
|
CI gfxreconstruct build queued with queue ID 284709. |
|
CI gfxreconstruct build # 5150 running. |
|
CI gfxreconstruct build # 5150 failed. |
|
CI gfxreconstruct build queued with queue ID 285414. |
|
CI gfxreconstruct build # 5161 running. |
davidd-lunarg
force-pushed
the
davidd-dxil-parsing
branch
from
1ff7fab
to
025f737
Compare
|
CI gfxreconstruct build queued with queue ID 285445. |
|
CI gfxreconstruct build # 5162 running. |
|
CI gfxreconstruct build # 5162 failed. |
davidd-lunarg
force-pushed
the
davidd-dxil-parsing
branch
from
025f737
to
d426303
Compare
|
CI gfxreconstruct build queued with queue ID 285554. |
| size_t demangled_name_start = mangled_name.find_first_of("?"); | ||
| size_t demangled_name_end = mangled_name.find_first_of("@"); | ||
|
|
||
| std::string demangled_name; |
There was a problem hiding this comment.
Since we check for empty string at the bottom, would it be safer here to explicitly init demangled_name to empty?
| #if defined(GFXRECON_DXC_SUPPORT) | ||
| // If D3D12_DXIL_LIBRARY_DESC::NumExports == 0, everything in the DXIL library is exported. Use | ||
| // reflection to get the list of exported shader names. | ||
| HRESULT hr; |
There was a problem hiding this comment.
There's a lot of machinery here - do we know how it might affect perf to do this work?
Wondering if any of these things can be a 1-time init and reusable thing? For instance all DxcCreateInstance calls
|
CI gfxreconstruct build # 5165 running. |
|
CI gfxreconstruct build # 5165 failed. |
No description provided.