Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid usage by waiting on CommandBuffer fence before resetting CommandBuffer #1795

Merged
merged 7 commits into from
Oct 23, 2024
Merged

Fix invalid usage by waiting on CommandBuffer fence before resetting CommandBuffer #1795

merged 7 commits into from
Oct 23, 2024

Conversation

bradgrantham-lunarg
Copy link
Contributor

@bradgrantham-lunarg bradgrantham-lunarg commented Oct 8, 2024 •
edited
Loading

  • Add fences to per-image copy resource
  • Save device in swapchain state
  • Give fence to QueueSubmit to signal
  • Wait on fence before resetting commandbuffer

See also KhronosGroup/Vulkan-ValidationLayers#8655

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 274089.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 274095.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4983 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4983 passed.

@bradgrantham-lunarg bradgrantham-lunarg requested review from davidd-lunarg and removed request for MarkY-LunarG October 8, 2024 20:12
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 275201.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5013 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5013 passed.

@bradgrantham-lunarg bradgrantham-lunarg added P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash. replay Issue with replay (capture was successful) vulkan labels Oct 10, 2024
@bradgrantham-lunarg bradgrantham-lunarg requested review from mikes-lunarg and removed request for locke-lunarg and davidd-lunarg October 10, 2024 18:07
mikes-lunarg
mikes-lunarg reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@mikes-lunarg mikes-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments. I haven't spent any time in this part of the code so I'm coming up to speed myself.

I don't understand this (why does it only apply to the first swapchain image?): https://github.com/LunarG/gfxreconstruct/blob/dev/framework/decode/vulkan_virtual_swapchain.cpp#L776-L783

And this also looks a little fishy (why is it using present_info->waitSemaphoreCount?)
https://github.com/LunarG/gfxreconstruct/blob/dev/framework/decode/vulkan_virtual_swapchain.cpp#L880-L884

framework/decode/vulkan_swapchain.h Outdated Show resolved Hide resolved
framework/decode/vulkan_virtual_swapchain.cpp Outdated Show resolved Hide resolved
@bradgrantham-lunarg
Fix invalid usage by waiting on cb fence before resetting cb
2425270 
* Add fences to per-image copy resource
* Save device in swapchain state
* Give fence to QueueSubmit to signal
* Wait on fence before resetting commandbuffer
@bradgrantham-lunarg
fix clang-format
dcd6a4d
@bradgrantham-lunarg bradgrantham-lunarg force-pushed the brad-fix-vswapchain-resetcommandbuffer branch from 18291b5 to dcd6a4d Compare October 22, 2024 22:56
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 284779.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5151 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5151 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 284802.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5152 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 284819.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 284834.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 284835.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 284850.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5156 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5156 passed.

@bradgrantham-lunarg bradgrantham-lunarg merged commit ae2a3cf into LunarG:dev Oct 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikes-lunarg mikes-lunarg mikes-lunarg approved these changes

Assignees
No one assigned
Labels
P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash. replay Issue with replay (capture was successful) vulkan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bradgrantham-lunarg @ci-tester-lunarg @mikes-lunarg