Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceleration structure meta-commands #1815

Merged

Conversation

fabian-lunarg
Copy link
Contributor

  • Extend capture/tracking to cover acceleration-structures (AS) and dependencies
  • Add meta-commands to rebuild AS during replay
  • create all stubs in replay, implement in follow-up

this PR belongs to portable raytracing initiative

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 280427.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5093 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 280446.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5094 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5094 passed.

@bradgrantham-lunarg bradgrantham-lunarg added the P1 Prevents an important capture from being replayed label Oct 20, 2024
@fabian-lunarg fabian-lunarg self-assigned this Oct 21, 2024
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 284069.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5142 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5142 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 284124.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5143 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5143 passed.

@MarkY-LunarG
Copy link
Contributor

Overall looks good to me. I did see you used the reserve bits, are you sure you can use those? I thought they were for something else.

@fabian-lunarg
Copy link
Contributor Author

Overall looks good to me. I did see you used the reserve bits, are you sure you can use those? I thought they were for something else.

thanks @MarkY-LunarG ! regarding the reserved enum-values. I first created new values but then realized those bits were reserved by @bartosz-muszarski-arm. they also matched the values used in his PR - it all lined up

@bradgrantham-lunarg
Copy link
Contributor

@fabian-lunarg if @MarkY-LunarG has approved then that's sufficient.

@bradgrantham-lunarg bradgrantham-lunarg removed their request for review October 23, 2024 05:47
@MarkY-LunarG
Copy link
Contributor

Overall looks good to me. I did see you used the reserve bits, are you sure you can use those? I thought they were for something else.

thanks @MarkY-LunarG ! regarding the reserved enum-values. I first created new values but then realized those bits were reserved by @bartosz-muszarski-arm. they also matched the values used in his PR - it all lined up

Thank you for verifying!

@fabian-lunarg fabian-lunarg merged commit dfa5b3e into LunarG:dev Oct 24, 2024
9 checks passed
@fabian-lunarg fabian-lunarg deleted the fabian_rebuild_acceleration_structures branch October 24, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Prevents an important capture from being replayed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants