-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acceleration structure meta-commands #1815
Add acceleration structure meta-commands #1815
Conversation
CI gfxreconstruct build queued with queue ID 280427. |
CI gfxreconstruct build # 5093 running. |
CI gfxreconstruct build queued with queue ID 280446. |
CI gfxreconstruct build # 5094 running. |
CI gfxreconstruct build # 5094 passed. |
CI gfxreconstruct build queued with queue ID 284069. |
CI gfxreconstruct build # 5142 running. |
CI gfxreconstruct build # 5142 failed. |
CI gfxreconstruct build queued with queue ID 284124. |
CI gfxreconstruct build # 5143 running. |
CI gfxreconstruct build # 5143 passed. |
Overall looks good to me. I did see you used the reserve bits, are you sure you can use those? I thought they were for something else. |
thanks @MarkY-LunarG ! regarding the reserved enum-values. I first created new values but then realized those bits were reserved by @bartosz-muszarski-arm. they also matched the values used in his PR - it all lined up |
@fabian-lunarg if @MarkY-LunarG has approved then that's sufficient. |
Thank you for verifying! |
this PR belongs to portable raytracing initiative