Separate dx12 codegen #1827
Open
Separate dx12 codegen #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the hard-coded dependency upon our Vulkan and the Khronos registry edit functionality (which the DX side really doesn't use). NOTE: This did require copying a few functions (like write) from the Khronos source to maintain consistency (so I added the Khronos copyright notice to the dx12_generators/base_generator.py file). This mostly is just copying functionality from the vulkan_generators/base_generator.py to the renamed dx12_generators/base_generator.py. The file in the dx12_generators directory was renamed from "dx12_base_generator.py" to "base_generator.py" because the "base_generators" directory scripts required it to be named that to work without more major edits to that shared code base. There will be a change coming with will break the dx12 depedence upon those base_generator scripts.
Move the beginFeature and endFeature method definition in the python so it's easier to find near the beginFile/endFile methods.
Move the Dx12 codegen to use its own base_decoder_body_generator script.
Some code for dx12 codegen was still left in the base_generators base_decoder_body_generator script which is no longer used by the dx12 codegen path.
Copy the base_replay_consumer_body_generator script to the dx12 path so that we don't get broken by the Khronos API codegen changes.
Copy the base_struct_decoders_body_generator into the Dx12 tree so that when the Khronos API codegen changes occur, they won't affect the DX12 tree.
Copy the base_struct_decoders_header_generator into the Dx12 tree so that when the Khronos API codegen changes occur, they won't affect the DX12 tree.
Copy the base_struct_object_mappers_body_generator content directly into the dx12_struct_object_mappers_body_generator script because it would only end up there. This is so that when the Khronos API codegen changes occur, they won't affect the DX12 tree.
Copy the base_struct_object_mappers_header_generator content directly into the dx12_struct_object_mappers_header_generator script because it would only end up there. This is so that when the Khronos API codegen changes occur, they won't affect the DX12 tree.
Dx12 codegen now uses its own scripts. So remove any dx12 specific items in the Vulkan or Base code.
Rename what used to be dx12_generators\dx12_base_generators.py which we had then renamed dx12_generators\base_generators.py to start the Dx12 codegen separation project, back to the original dx12_generators\dx12_base_generators.py filename.
MarkY-LunarG
requested review from
jzulauf-lunarg,
locke-lunarg,
bradgrantham-lunarg and
davidd-lunarg
|
CI gfxreconstruct build queued with queue ID 285599. |
|
CI gfxreconstruct build # 5166 running. |
|
CI gfxreconstruct build # 5166 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate out the DX12 codegen from the Vulkan codegen. The DX12 codegen was heavily tied in with the Vulkan codegen which leads to difficulty when trying to add in other Khronos API codegen (since we have to be careful of breaking other APIs).