dx12 dump: Check duplicated notes #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 310593. |
locke-lunarg
changed the title
locke-lunarg
force-pushed
the
dep-notes
branch
from
1f592db
to
d85cdb0
Compare
|
CI gfxreconstruct build queued with queue ID 310607. |
Since of "before" and "after", the infos are written twice. But the infos paths are the same, so the second time would override the first time. It doesn't duplicate. But notes are array. The second time won't override the first time. It causes duplicated data. In this case, it needs to check if the note is duplicated before writting.
locke-lunarg
force-pushed
the
dep-notes
branch
from
d85cdb0
to
3f724c7
Compare
|
CI gfxreconstruct build queued with queue ID 310609. |
|
CI gfxreconstruct build # 5408 running. |
|
CI gfxreconstruct build # 5408 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since of "before" and "after", the infos are written twice. But the infos paths are the same so the second time would override the first time. It doesn't duplicate. But notes are array. The second time won't
override the first time. It causes duplicated data. In this case, it
needs to check if the note is duplicated before writing.