Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pipfiles with dependencies #65

Merged
merged 7 commits into from
Nov 17, 2023
Merged

Add Pipfiles with dependencies #65

merged 7 commits into from
Nov 17, 2023

Conversation

AlinderS
Copy link
Collaborator

@AlinderS AlinderS commented Oct 2, 2023

Pipfiles are created as standard by pipenv and contain the dependencies for running the project.

Pipfiles are created as standard by pipenv and contain the dependencies
for running the project.
Pipfile Outdated Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
Remove dependencies on pycodestyle and any specific Python version.
Add the tools demonstrated in presentation 4.
There are two dependencies on RISE currently, the regular `rise`
that is used with Jupyter Notebook < 7 and `jupyterlab-rise` which is
used with Jupyter Notebook >= 7 and JupyterLab.
It is being handled as a system level dependency instead.
@AlinderS

This comment was marked as outdated.

`black` has the jupyter extras and is listed as a devel dependency since
it is not used or demonstrated at runtime.
Copy link
Collaborator

@eerovaher eerovaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use pipenv myself, so I can't do a proper review, but Pipfile.lock with its 2000 lines seems a bit excessive to me.

@AlinderS
Copy link
Collaborator Author

I am basing my decision to include the lockfile in the tree on this thread. I personally don't care super much either way. I want to have the Pipfile in the tree because otherwise pipenv will generate one every time I enter the virtual environment, and it contains human-accessible information that is useful for other people. The lockfile will make sure one gets exactly the right versions (a deterministic build) which isn't that important to us.

@eerovaher
Copy link
Collaborator

This repository is meant to be a very basic introduction to Python. If there's anything here that depends critically on the exact version of dependencies then we are in deep trouble even if there is a Pipfile.lock that provides exactly those versions.

@AlinderS
Copy link
Collaborator Author

I have removed Pipfile.lock from the tree. I think with this change the PR is ready to merge, and I think it is best to squash and merge.

@eerovaher eerovaher mentioned this pull request Nov 13, 2023
@AlinderS AlinderS merged commit e347a7e into master Nov 17, 2023
@AlinderS AlinderS deleted the pipfile branch November 17, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants