Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): animate sorting of collapsible sections #2562

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/components/form/form.scss
Original file line number Diff line number Diff line change
Expand Up @@ -286,3 +286,14 @@ limel-code-editor {
}

@import './row/row.scss';

limel-collapsible-section {
transition: transform 0.3s ease-in-out;

&.move-up-transition {
transform: translateY(-100%);
}
&.move-down-transition {
transform: translateY(100%);
}
Comment on lines +293 to +298
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only works when all collapsible sections have the same size. So for example if one is closed and one is open, this doesn't work and make a silly visual effect.

}
48 changes: 47 additions & 1 deletion src/components/form/templates/array-field-collapsible-item.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,53 @@ export class CollapsibleItemTemplate extends React.Component {

private handleAction(event: CustomEvent<Action & Runnable>) {
event.stopPropagation();
event.detail.run(event);

const moveTransitionSpeed = 300; // This must be kept the same as the transition speed in the CSS
const up = 'move-up-transition';
const down = 'move-down-transition';
// Access the DOM element
const section: HTMLLimelCollapsibleSectionElement = this.refs.section;

// Determine whether it's a move up or move down action
const isMoveUp = event.detail.id === 'up';

// Get the previous and next collapsible sections
const previousSection =
section.previousElementSibling as HTMLLimelCollapsibleSectionElement;
const nextSection =
section.nextElementSibling as HTMLLimelCollapsibleSectionElement;

// Add the appropriate class to the current section
if (isMoveUp) {
section.classList.add(up);
} else {
section.classList.add(down);
}

// Add the opposite class to the adjacent sections
if (previousSection && isMoveUp) {
previousSection.classList.add(down);
}

if (nextSection && !isMoveUp) {
nextSection.classList.add(up);
}

// Remove the classes after a short delay to trigger the transition
setTimeout(() => {
section.classList.remove(up, down);

if (previousSection) {
previousSection.classList.remove(down);
}

if (nextSection) {
nextSection.classList.remove('move-up-transition');
}

// Perform the action
event.detail.run(event);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to wait for the transitions to happen, and then update the index number and simultaneously and instantly remove the transition classes. This timing however doesn't seem to work always. Maybe the implementation should be totally different. I don't know

}, moveTransitionSpeed); // Adjust the delay to match your transition duration
}

private isDeepEmpty(data) {
Expand Down