-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form): animate sorting of collapsible sections #2562
Draft
Kiarokh
wants to merge
1
commit into
main
Choose a base branch
from
collapible-sections-transitions-in-form
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−1
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,7 +103,53 @@ export class CollapsibleItemTemplate extends React.Component { | |
|
||
private handleAction(event: CustomEvent<Action & Runnable>) { | ||
event.stopPropagation(); | ||
event.detail.run(event); | ||
|
||
const moveTransitionSpeed = 300; // This must be kept the same as the transition speed in the CSS | ||
const up = 'move-up-transition'; | ||
const down = 'move-down-transition'; | ||
// Access the DOM element | ||
const section: HTMLLimelCollapsibleSectionElement = this.refs.section; | ||
|
||
// Determine whether it's a move up or move down action | ||
const isMoveUp = event.detail.id === 'up'; | ||
|
||
// Get the previous and next collapsible sections | ||
const previousSection = | ||
section.previousElementSibling as HTMLLimelCollapsibleSectionElement; | ||
const nextSection = | ||
section.nextElementSibling as HTMLLimelCollapsibleSectionElement; | ||
|
||
// Add the appropriate class to the current section | ||
if (isMoveUp) { | ||
section.classList.add(up); | ||
} else { | ||
section.classList.add(down); | ||
} | ||
|
||
// Add the opposite class to the adjacent sections | ||
if (previousSection && isMoveUp) { | ||
previousSection.classList.add(down); | ||
} | ||
|
||
if (nextSection && !isMoveUp) { | ||
nextSection.classList.add(up); | ||
} | ||
|
||
// Remove the classes after a short delay to trigger the transition | ||
setTimeout(() => { | ||
section.classList.remove(up, down); | ||
|
||
if (previousSection) { | ||
previousSection.classList.remove(down); | ||
} | ||
|
||
if (nextSection) { | ||
nextSection.classList.remove('move-up-transition'); | ||
} | ||
|
||
// Perform the action | ||
event.detail.run(event); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have to wait for the transitions to happen, and then update the index number and simultaneously and instantly remove the transition classes. This timing however doesn't seem to work always. Maybe the implementation should be totally different. I don't know |
||
}, moveTransitionSpeed); // Adjust the delay to match your transition duration | ||
} | ||
|
||
private isDeepEmpty(data) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this only works when all collapsible sections have the same size. So for example if one is closed and one is open, this doesn't work and make a silly visual effect.