Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate_SerialCom ESP32 project example #351

Merged
merged 5 commits into from
Sep 1, 2022
Merged

Conversation

Salem-Tho
Copy link
Member

@Salem-Tho Salem-Tho commented Sep 1, 2022

By submiting this PR, you agree with the associated license (Apache 2.0 or MIT) and with our Contributor License Agreement (CLA).

Before to begin

Thank you for contributing to the Luos project!

Before to begin, please follow these steps:

  • Ensure that this PR is not a duplicate.
  • Assign @Simonbdy to this PR
  • Add the PR to the Luos contribution project

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.

PR Description section

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@Salem-Tho Salem-Tho self-assigned this Sep 1, 2022
@Salem-Tho Salem-Tho added the type bug Something isn't working label Sep 1, 2022
@Salem-Tho Salem-Tho added this to the 2.6.1 milestone Sep 1, 2022
@Salem-Tho Salem-Tho force-pushed the feat/gateserial_esp branch 2 times, most recently from e58249b to f19b386 Compare September 1, 2022 09:44
Copy link
Member

@JeromeGalan JeromeGalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK !
I'll just add "$PROJECT_DIR" missing in platformio.ini

@JeromeGalan JeromeGalan changed the base branch from main to rc_2.6.1 September 1, 2022 13:58
@JeromeGalan JeromeGalan merged commit 6cf2bbe into rc_2.6.1 Sep 1, 2022
@JeromeGalan JeromeGalan deleted the feat/gateserial_esp branch September 1, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants