Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure unit test default scenario and cleanup build and stuff #424

Merged
merged 15 commits into from
Feb 14, 2023
Merged

Secure unit test default scenario and cleanup build and stuff #424

merged 15 commits into from
Feb 14, 2023

Conversation

nicolas-rabault
Copy link
Member

@nicolas-rabault nicolas-rabault commented Feb 13, 2023 •
edited by JeromeGalan
Loading

PR Description section

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.

WARNING: Do not edit the checklist below.

Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault self-assigned this Feb 13, 2023
@nicolas-rabault nicolas-rabault force-pushed the feat/secure_tests_default_scenario branch from fa71dd7 to 7a4136d Compare February 13, 2023 16:02
@nicolas-rabault nicolas-rabault changed the title Secure unit test default scenario and remove non default things Secure unit test default scenario and cleanup build and stuff Feb 13, 2023
@nicolas-rabault nicolas-rabault force-pushed the feat/secure_tests_default_scenario branch from 49164b5 to 620341b Compare February 13, 2023 17:50
@nicolas-rabault nicolas-rabault force-pushed the feat/secure_tests_default_scenario branch from 620341b to 886515d Compare February 14, 2023 08:32
@nicolas-rabault nicolas-rabault added this to the 2.9.0 milestone Feb 14, 2023
@nicolas-rabault nicolas-rabault force-pushed the feat/secure_tests_default_scenario branch 3 times, most recently from 8f6effd to 53ebe7c Compare February 14, 2023 17:05
@nicolas-rabault
Remove useless transmit_msg pointer
ba2ab08
@nicolas-rabault
Remove very suspect messaging pointers on the default scenario
d3e1ef2
@nicolas-rabault
Completely remove tx_msg from default scenarios
8e0c7cc
@nicolas-rabault
Use a passive DEFAULT_CMD for default scenario message command
683b030
@nicolas-rabault
Fix a potential segfault with try catch
2ff6030
@nicolas-rabault
Remove streaming_channels of the default scenario
0b6241e
@nicolas-rabault
Remove useless code on default scenario
03d4838
@nicolas-rabault
Group all luos_assert unit test function at the same place
ad1ae47
@nicolas-rabault
Create a STUB HAL used by testU
0f43957
@nicolas-rabault
Remove unused test template to avoid maintainability issues on unit t…
4d6b641 
…est.
@nicolas-rabault
Secure unit test services detection
1a71b87
@nicolas-rabault
Remove Reset_Context because it wasn't used.
3c4b297
@nicolas-rabault
Simplify unit test assert.
66d528d
@nicolas-rabault
Fix test_robus Mask 4096 limits
58bcc12
@nicolas-rabault
Fix test_robus wrong assert test
7c38415
@nicolas-rabault nicolas-rabault force-pushed the feat/secure_tests_default_scenario branch from 53ebe7c to 7c38415 Compare February 14, 2023 17:34
JeromeGalan
JeromeGalan approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@JeromeGalan JeromeGalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native is easier and more secured liek this. Good job.

@JeromeGalan JeromeGalan merged commit 6bdaddc into feat/improve_unit_test Feb 14, 2023
@JeromeGalan JeromeGalan deleted the feat/secure_tests_default_scenario branch February 14, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeGalan JeromeGalan JeromeGalan approved these changes

Assignees

@nicolas-rabault nicolas-rabault

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-rabault @JeromeGalan