Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Frosthaven Rules not enabled by default if Frosthaven chosen as edition #239

Closed
TheSquinter opened this issue Apr 18, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@TheSquinter
Copy link
Contributor

Just thought I'd bring up that it might be a good idea to enable some of the Frosthaven Rules by default if the edition is set to FH, like the way 'Frosthaven style' setting is.

Onces like the Solo rules and Hazardous terrain and maybe allies deck are part of the core rules anyway so should probably be enabled, whereas the others are more app feature related.

@Lurkars
Copy link
Owner

Lurkars commented Apr 18, 2023

Okay, misunderstanding here I think. The rules you mention have the label "ALWAYS" there, because those settings are to explicit use FH rules when NOT paying FH. So all this rules already apply when playing Frosthaven even when unchecked!

Any suggestion on how to make this more clear?

@TheSquinter
Copy link
Contributor Author

Ohh so you're saying these settings are always enabled when edition = FH? Except maybe the "show loot apply dialog"?

image

Could just tick them to make it clear they're being used? Or grey them out?

@Lurkars
Copy link
Owner

Lurkars commented Apr 18, 2023

Ah simple and I didn't came up, yes great idea. Will just check them and disable when on FH!

@Lurkars Lurkars self-assigned this Apr 18, 2023
@Lurkars Lurkars added enhancement New feature or request in progress Currently working on this labels Apr 18, 2023
Lurkars added a commit that referenced this issue Apr 18, 2023
…prove ally/allied marker, small fixes + improvements
@Lurkars
Copy link
Owner

Lurkars commented Apr 18, 2023

Should be changed now in v0.60.1

@Lurkars Lurkars assigned TheSquinter and unassigned Lurkars Apr 18, 2023
@Lurkars Lurkars added to test Should be fixed, but needs proper testing and removed in progress Currently working on this labels Apr 18, 2023
@Lurkars Lurkars removed the to test Should be fixed, but needs proper testing label Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants