Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage multiple campaigns/parties #371

Closed
4 of 6 tasks
mentonin opened this issue Aug 26, 2023 · 6 comments
Closed
4 of 6 tasks

Manage multiple campaigns/parties #371

mentonin opened this issue Aug 26, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@mentonin
Copy link
Contributor

mentonin commented Aug 26, 2023

  • Switching between campaigns (single-party)
  • Single campaign export/import
  • Switching parties within same campaign Separate issue if really required
  • Single party export/import Separate issue if really required
  • Switching characters within same party (implemented with absent characters)
  • Single character export/import
@mentonin mentonin added the enhancement New feature or request label Aug 26, 2023
@Lurkars
Copy link
Owner

Lurkars commented Aug 26, 2023

Here I have to admit that the current feature of party switching needs a re-labeling to campaign switching, because actually no data is shared between parties (as per rules, like global achievements for example), so actually this is campaign switching (and as labeled with party already available in the campaign management menu). I think that came from my initial misunderstanding of the rules (this feature is really old in comparison to some stuff). So actually, this issue should be more about: implement real party switching by keeping all global stuff etc (which is currently not the case). So happy for you: this feature is already implement, but in the bad side is labeled wrong and the expected feature from label is actually missing 😅

So to sum up the feature: a party is actually a single party campaign with separate stored

  • achievements of any kind
  • edition (so create a new party change edition from GH to FH and you have your GH campaign and FH campaign parallel in a single game state, and single game code with server feature usage)
  • unlocks (scenarios, items, treasures etc) except characters which is wrong, just noticing
  • battle goals config
  • reputation, prosperity, buildings etc

So yeah, this needs rework of course and actually add real support for multiple parties in a single campaign and as first change, update all labels and texts about campaign and not party switching (and fix to move character unlocks also to the campaign and not global game state).

Lurkars added a commit that referenced this issue Aug 27, 2023
@Lurkars
Copy link
Owner

Lurkars commented Aug 27, 2023

So as first step, in v0.74.0 I renamed all the current functionality to what it is, a multi-campaign management. Next step is to do the real multi-party management on a campaign.

@Lurkars Lurkars added the pending Additional information/feedback requested label Aug 27, 2023
@mentonin
Copy link
Contributor Author

mentonin commented Aug 28, 2023

That is nice. I think it would be wise to track what needs to be implemented and develop some tests. Off the top of my head, we are looking for the following features:

  • Easy switch between campaigns
  • Easy switch between parties in a campaign
  • Export subset of tracked campaigns
  • Export subset of tracked parties
  • Import parties into a campaign (without overwriting current parties)
  • Import campaigns (without overwriting current campaigns)
  • Saved on campaign level: scenario status, global achievements, treasures, buildings, available items, calendar status, inspiration, morale, town resources, unlocked characters, ...
  • Saved on party level: character data, party achievements, used items, reputation, ...
  • Saved on global level: ?

Honestly, I believe switching campaigns is much more useful than switching parties in a campaign, but that could be just me. Maybe see if someone needs the multi party functionality before working on it?

@Lurkars
Copy link
Owner

Lurkars commented Aug 28, 2023

I checked the one point that should already be implemented like this. For the import export you're right, the import should not overwrite. So I will definitely change that (also need to switch label there too, it's import/export campaign currently not party). And you're also right (and that also caused the misunderstanding on my side), when people ask for multi party support they almost always mean multi campaign support and that why I implemented feature as it is. So I will also definitely not focus on real multi party support unless requested.

Lurkars added a commit that referenced this issue Aug 28, 2023
@Lurkars Lurkars added backlog This will not be worked on yet, but will come in future and removed pending Additional information/feedback requested labels Aug 28, 2023
@Lurkars
Copy link
Owner

Lurkars commented Aug 28, 2023

Import will now only overwrite if name and id is matching, otherwise new campaign is created. So multiple campaign management should be complete here and I keep this in backlog if multiple parties becoming relevant sometimes.

@mentonin mentonin changed the title Manage multiple campaigns Manage multiple campaigns/parties Aug 28, 2023
@Lurkars Lurkars removed the backlog This will not be worked on yet, but will come in future label Oct 14, 2023
@Lurkars
Copy link
Owner

Lurkars commented Oct 14, 2023

Okay, I think I'll close this. If multiple parties is requested someday, a new issue will be created.

@Lurkars Lurkars closed this as completed Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants