Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Trial Deck card The Trial of Strategy #595

Open
dhyanna opened this issue Jul 15, 2024 · 18 comments
Open

Support for Trial Deck card The Trial of Strategy #595

dhyanna opened this issue Jul 15, 2024 · 18 comments
Assignees
Labels
enhancement New feature or request spoiler This containing spoiler to test Should be fixed, but needs proper testing

Comments

@dhyanna
Copy link

dhyanna commented Jul 15, 2024

Is your feature request related to a problem? Please describe.

The Trial of Strategy card requires the player to draw and keep all three battle cards every scenario until the trial is completed. The trial is complete when the player successfully completes all three battle goals during scenario play. The battle goal interface currently does not support keeping more than one battle goal, nor does the scenario complete screen allow a player to tally checks for more than one battle goal completed.

Describe the solution you'd like

Ideally, support for the trial cards, but aside from formal support for the trial cards at least have a way to at least support the Trial of Strategy.

Describe alternatives you've considered

Perhaps in the battle goal selection interface, a way to toggle the Trial of Strategy and the interface allow selection of all three battle goals. There would need to maintain redraw capabilities as current, since the trial card allows for redrawing in the event two battle goals drawn are mutually exclusive. The scenario complete interface would need to know that player had multiple battle goals selected

Additional context

No response

@dhyanna dhyanna added the enhancement New feature or request label Jul 15, 2024
Lurkars added a commit that referenced this issue Oct 25, 2024
… scenario stats, many small fixes and improvements
@Lurkars
Copy link
Owner

Lurkars commented Oct 25, 2024

Support for Trial Deck now in v0.102.2.

Of course Building 81 required and enable Trials in Settings! To see the character's trial, open the character sheet. There is a Trial Icon under the Personal Quest. Some trials are applied automatically. Trial of Strategy should hopefully work as expected. Trials can be marked as completed in Scenario Summary.

Happy about feedback and testing!

@Lurkars Lurkars added to test Should be fixed, but needs proper testing spoiler This containing spoiler labels Oct 25, 2024
@Lurkars Lurkars assigned dhyanna and unassigned Lurkars Oct 25, 2024
@dhyanna
Copy link
Author

dhyanna commented Oct 28, 2024 via email

@dhyanna
Copy link
Author

dhyanna commented Oct 28, 2024 via email

@dhyanna
Copy link
Author

dhyanna commented Oct 28, 2024 via email

@Lurkars
Copy link
Owner

Lurkars commented Oct 29, 2024

Thanks for the detailed review. I will take a deeper look later. Just short answering this:

I did notice that the trial card number to input on the character did not align with the card numbers on Worldhaven github at https://github.com/any2cards/worldhaven/tree/master/images/trial-cards/frosthaven.

Totally possible, that I worked with the first print data of worldhaven. Will take a look and compare, then fix cards.

Does Secretariat auto-draw the next trial in the trial deck for the player and add that to their character sheet? (I’m guessing not since I don’t see support for the trial deck itself.)

Yes, it auto draws a new trial! (I think at start of next scenario). Didn't see a need to implement the full deck, so it's just a new trial on the Character Sheet (next one from deck).

@Lurkars
Copy link
Owner

Lurkars commented Oct 29, 2024

I did notice that the trial card number to input on the character did not align with the card numbers on Worldhaven github at https://github.com/any2cards/worldhaven/tree/master/images/trial-cards/frosthaven.

Okay, we have a problem here:
I used the card numbers of first printing (and put it in correct order!). So Weakness is card 348 and first card in deck.
I have no idea why, but it seems they changed the card numbers in second printing. So Weakness is card 360 there. Which is more confusing (no idea, if they put in the right order in 2nd printing), because now highest card (360) should be drawn first.

So by now, I just start with 348 and increment. With second edition, I need to do the opposite (and used opposite label). I will try to add a toggle for 2nd printing and put some math on it to get first printing card ID for it.

Still think, it was stupid to change card IDs between editions...

@Lurkars
Copy link
Owner

Lurkars commented Oct 29, 2024

So now easy answer for Frozen Fist and the Trial of Trials. Actually, start and end of round is not completely defined. So if OwtM and you want not to trigger a new Battle Goal, just click "Next Round", Trial of Trials is not triggered and THEN apply the damage to fist. So you can define that order by yourself.

@dhyanna
Copy link
Author

dhyanna commented Oct 29, 2024 via email

@dhyanna
Copy link
Author

dhyanna commented Oct 29, 2024 via email

@dhyanna
Copy link
Author

dhyanna commented Oct 29, 2024 via email

@Lurkars
Copy link
Owner

Lurkars commented Oct 29, 2024

So changes in v0.102.5:

  • Go to Campaign Management to toggle to "second edition" for Frosthaven for new Card Id support (708 - cardnumber is translation for 1st vs. 2nd printing, so it just displays other numbers
  • Remove draw battle goal, when damage is suffered "between rounds"
  • make Battle Goal list scrollable in Scenario Summary

So I am happy, if you can checkout v0.102.5 and provide feedback, if your issues are solved with this.

Lurkars added a commit that referenced this issue Oct 29, 2024
Lurkars added a commit that referenced this issue Oct 29, 2024
@dhyanna
Copy link
Author

dhyanna commented Oct 29, 2024 via email

Lurkars added a commit that referenced this issue Oct 29, 2024
@dhyanna
Copy link
Author

dhyanna commented Oct 29, 2024 via email

@Lurkars
Copy link
Owner

Lurkars commented Oct 30, 2024

I think you we're just to quick. Release was still building on my comment. It was released like 10-15 minutes after your comment. So check again now.

@Lurkars
Copy link
Owner

Lurkars commented Oct 30, 2024

How does Secretariat know what is the next card on the top of the deck. I’m dropping into Secretariat’s trial support having my four-player group already drawn the deck down to just the last two cards in the deck. How would Secretariat know the cards we have already drawn and completed?

Just to answer this: I just store latest index in party data. So I have the deck here in correct (1st printing!) order:

https://github.com/Lurkars/gloomhavensecretariat/blob/main/data/fh/trials.json

and here is the index stored:

so when 5 cards are already dealt, index 4 is stored. Next player who finished trial, will get next card (so index 5, meaning 6th card in the deck).

Since I know the deck is sorted in order, if you manually set the card on player sheet, I just check for highest index number used on characters and adjust stored deck index to it. So if you already dealt x-many cards physically, just set the correct trail card on each player, index get's updated and next card dealt will be x+1 card.

@dhyanna
Copy link
Author

dhyanna commented Oct 30, 2024 via email

@dhyanna
Copy link
Author

dhyanna commented Nov 4, 2024 via email

@Lurkars
Copy link
Owner

Lurkars commented Nov 5, 2024

Cannot reproduce why battle goals/trial completion did not work for one character. Maybe send an Email with a data dump, if this appears in future. Drawing new trials worked after starting new scenario, I fixed this now in v0.102.7. So new trial card should be drawn after scenario finish. I also added support for Trial of Victory just by making the Battle Goal drawing to just show one 2-check card. You can then click "redraw" or "draw another card to change this card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spoiler This containing spoiler to test Should be fixed, but needs proper testing
Projects
None yet
Development

No branches or pull requests

2 participants