Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.5.1: Dictionaries no longer loading #469

Closed
jamesdeluk opened this issue Aug 16, 2024 · 7 comments
Closed

3.5.1: Dictionaries no longer loading #469

jamesdeluk opened this issue Aug 16, 2024 · 7 comments
Assignees
@jzohrab
Labels
bug Something isn't working fixed Fixed in develop or master, to be launched.

Comments

@jamesdeluk
Copy link

Upgraded to 3.5.1, dictionaries typically don't load. Perhaps 1 time in 10 they load.

Downgraded to 3.5.0, they load again every time.

Specifically, https://korean.dict.naver.com/koendict/#/search?query=### and https://en.dict.naver.com/#/search?query=###

Possibly related to #464 and #459?
@jzohrab
Copy link
Collaborator

jzohrab commented Aug 16, 2024

Well that's a drag, sorry about that! I tested with some other dicts and it was fine, but obv. it's no good. So I'll revert that change and maybe we can work something else out. Should be out soon, thanks.

@jamesdeluk
Copy link
Author

It happens 😄 Maybe someone else can double-check to ensure it's not just an issue I'm having.

@cblanken
Copy link
Contributor

It happens 😄 Maybe someone else can double-check to ensure it's not just an issue I'm having.

@jamesdeluk I'm having trouble replicating this. Could you post what browser you're using and the version?

For me they load immediately, but it's possible they won't display immediately if your connection is slow. Do they show up if you wait a while (10-15 seconds) after selecting a term or does the dictionary pane just keep the background color without any indication of loading?

Also if you have any other dictionaries failing to load please post them as well so I can check them. Thanks.

@jamesdeluk
Copy link
Author

Firefox 129.0.2 (64-bit) on Windows 11.

I've just re-upgraded to 3.5.1 and the issue persists.

Waiting for extended periods doesn't work.

Other dictionaries (e.g. https://en.wiktionary.org/wiki/###) load fine.

The network does do a GET request for the URL, but nothing loads.

When I click off and on again, I get en.dict.naver.com content already loaded. (or korean.dict.naver.com content already loaded.) in the console, so it thinks it's loaded.

Downgrading to 3.5.0, everything loads again instantly. After the GET request, there are a bunch more as the page loads.

@jzohrab
Copy link
Collaborator

jzohrab commented Aug 24, 2024

Hey @jamesdeluk , I'm going to back out the change in 3.5.1. Too bad :-/ but it's causing other issues too. @cblanken spent a whack of time trying to come up with workarounds, but no dice. Thanks for the detail!

@jzohrab jzohrab self-assigned this Aug 24, 2024
@jzohrab jzohrab added the bug Something isn't working label Aug 24, 2024
@jzohrab jzohrab added this to Lute-v3 Aug 24, 2024
@jzohrab jzohrab moved this to Todo in Lute-v3 Aug 24, 2024
cblanken added a commit to cblanken/lute-v3 that referenced this issue Aug 24, 2024
@cblanken
Add sandbox to dictionary tab iframes
5f9bd35 
One possible solution to preven dictionary iframes from stealing focus is to
enable the CSP sandbox on each iframe. If a bare `sandbox` attribute is used,
then autofocus from iframes should be blocked. Unfortunately this has the side
effect of blocking some online dictionary that require additional feature
policies such as `allow-same-origin` and `allow-scripts`.

In particular the following dictionaries mentioned in issue LuteOrg#469 require these policies
to load correctly:
- https://korean.dict.naver.com/koendict/#/search?query=###
- https://en.dict.naver.com/#/search?query=###
@cblanken cblanken mentioned this issue Aug 24, 2024
Draft
@jzohrab
Copy link
Collaborator

jzohrab commented Aug 24, 2024

Change reverted, this should be fixed when 3.5.2 is launched. Thanks @jamesdeluk and @cblanken , cheers!

@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Aug 24, 2024
@jzohrab jzohrab moved this from Todo to Done in Lute-v3 Aug 24, 2024
jzohrab added a commit that referenced this issue Aug 24, 2024
@jzohrab
Revert "Merge pull request #459 from cblanken/issue-379-dictionary-ta…
374baa3 
…b-autofocus"

PR 459 tried to address the dictionary fram pulling focus, but that PR
caused other issues:

- term form losing focus early - #471
- some dictionaries not loading - #469

This reverts commit 397211c, reversing
changes made to 1284c25.
@jzohrab
Copy link
Collaborator

jzohrab commented Aug 27, 2024

Launched in 3.5.2

@jzohrab jzohrab closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzohrab jzohrab

Labels
bug Something isn't working fixed Fixed in develop or master, to be launched.
Projects
Lute-v3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jzohrab @cblanken @jamesdeluk