Feature/measure ram cpu #1
Conversation
Remove percentage signs, replace extra word to number in file names.
| @@ -0,0 +1 @@ | |||
| docker build . -t remote_atf_server | |||
There was a problem hiding this comment.
@LuxoftAKutsan I would propose to add next line to script
#!/bin/bash
| ip addr | grep -E "inet " | tr -s " " | cut -d ' ' -f 3| cut -d '/' -f 1 | ||
|
|
||
| echo " ls /home/developer " | ||
| ls /home/developer |
There was a problem hiding this comment.
@LuxoftAKutsan What is purpose to display this list of files on start?
| CPUS=2 | ||
| docker rm $CONTAINER_NAME | ||
|
|
||
| echo $1 $2 $3 |
There was a problem hiding this comment.
@LuxoftAKutsan I would propose to add some description to these variables or do not display them at all.
| std::pair<std::string, int> | ||
| ExecuteCommandBg(const std::string &bash_command); | ||
|
|
||
|
|
There was a problem hiding this comment.
@LuxoftAKutsan Please remove the redundant empty line.
| @@ -0,0 +1,63 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| # apt-get install sysstat linux-tools-common | |||
There was a problem hiding this comment.
@LuxoftAKutsan Could this commented instruction be removed from the script?
| } | ||
|
|
||
| function measure_docker() { | ||
| RECORD=$(docker stats --format "{{.Name}} {{.CPUPerc}} {{.MemUsage}} {{.PIDs}}" --no-stream | grep $CONTAINTER_NAME) |
There was a problem hiding this comment.
@LuxoftAKutsan This line too long and contains redundant whitespaces. Could it be fixed?
|
|
||
| def parse_ps(line): | ||
| # time + ps --no-headers --format "start %cpu cp cputime %mem sz thcount" | ||
| line = line.split() |
There was a problem hiding this comment.
@LuxoftAKutsan I would propose to avoid storing different types of data into one variable.
line = line.split() => single string -> collection of strings
| record["thcount"] = int(line[7]) | ||
| return record | ||
|
|
||
| def sdl_start_time_docker(lines): |
There was a problem hiding this comment.
@LuxoftAKutsan Function name does not describe what it actually do, for my opinion. Could it be renamed to fit more precisely?
This comment relates to other functions of this PR too.
| plt.ylabel(ylable) | ||
| plt.xlabel(xlable) | ||
| plt.savefig("{}_{}.png".format(file_pattern, ylable), format='png') | ||
| # plt.show() |
There was a problem hiding this comment.
@LuxoftAKutsan I would propose to remove commented code.
Add docker for remote adapter server
Fix compilation for raspberry pi
Add support of execution remote background tasks
Add python script that collects ram\cpu statistics of SDL
Scripts: #1