Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering of disallowed vehicle data for OnVehicleData notification #36

Closed
wants to merge 1 commit into from
Closed

Fix filtering of disallowed vehicle data for OnVehicleData notification #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions ...nager/rpc_plugins/vehicle_info_plugin/src/commands/mobile/on_vehicle_data_notification.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,37 @@ void OnVehicleDataNotification::Run() {
}
}

LOG4CXX_DEBUG(logger_,
"Number of Notifications to be send: " << notify_apps.size());

for (size_t idx = 0; idx < notify_apps.size(); idx++) {
CommandParametersPermissions params_permissions;
application_manager_.CheckPolicyPermissions(
notify_apps[idx],
window_id(),
MessageHelper::StringifiedFunctionID(
mobile_api::FunctionID::OnVehicleDataID),
appSO[idx].enumerate(),
&params_permissions);

for (const auto& param : appSO[idx].enumerate()) {
const auto& allowed_params = params_permissions.allowed_params;
auto param_allowed = allowed_params.find(param);
if (allowed_params.end() == param_allowed) {
LOG4CXX_DEBUG(logger_,
"Param " << param << " is not allowed by policy for app "
<< notify_apps[idx]->app_id()
<< ". It will be ignored.");
appSO[idx].erase(param);
}
}

if (appSO[idx].empty()) {
LOG4CXX_DEBUG(logger_,
"App " << notify_apps[idx]->app_id()
<< " will be skipped: there is nothing to notify.");
continue;
}

LOG4CXX_INFO(logger_,
"Send OnVehicleData PRNDL notification to "
"Send OnVehicleData notification to "
<< notify_apps[idx]->name().c_str() << " application id "
<< notify_apps[idx]->app_id());
(*message_)[strings::params][strings::connection_key] =
Expand Down