Revision - SDL-0126 ATF support of additional transports (BT and USB) #11
Conversation
aderiabin
requested review from
AKalinich-Luxoft,
LitvinenkoIra,
dboltovskyi,
KhrystynaDubovyk and
YaroslavLutsenko
aderiabin
force-pushed
the
revision/0126-atf-additional-transports
branch
from
3bdef3d to
277f496
Compare
aderiabin
force-pushed
the
revision/0126-atf-additional-transports
branch
from
277f496 to
8f780a2
Compare
|
@aderiabin why did you remove the diagram? As I can see it is still used in the proposal. Probably you should provide an updated diagram? |
|
|
||
| ATF should be able to connect to multiple Mobile transport adapters and provide ability to use any of them to test engineer. | ||
|
|
||
| Test engineer should be able to to create sessions on provided by ATF mobile transport adapters. |
There was a problem hiding this comment.
| Test engineer should be able to to create sessions on provided by ATF mobile transport adapters. | |
| Test engineers should be able to create sessions on provided by ATF mobile transport adapters. |
There was a problem hiding this comment.
@AKalinich-Luxoft Updated (see 5716e7b)
| - DisconnectFromSDL - Disconnects from SDL | ||
| - GetSDLConnectionStatus - Provides status of connection to SDL | ||
|
|
||
| It should provide host and port of TCP server for raw binary data communication with ATF on establishing successful connection to SDL. |
There was a problem hiding this comment.
@aderiabin I believe you should clarify who is "it" and how it can provide this information to ATF
There was a problem hiding this comment.
@AKalinich-Luxoft, @dboltovskyi Updated (see 5716e7b)
| Create Android mobile application as a part of ATF infrastructure. | ||
|
|
||
| Mobile application should use HTTP connection with REST protocol for control communication with ATF using next API: | ||
| - GetDeviceInfo - Provides device's information |
There was a problem hiding this comment.
@aderiabin probably some details would be useful here for understanding what is a device info
There was a problem hiding this comment.
@AKalinich-Luxoft Details have been added. (see 5716e7b)
|
@AKalinich-Luxoft Regarding the comment:
I'm able to see a new diagram if new version of proposal is opened by link https://github.com/LuxoftSDL/sdl_evolution/blob/8f780a2b5f652d4a5b675dcd6cb789a3b0452244/proposals/0126-atf-additional-transports.md |
| - DisconnectFromSDL - Disconnects from SDL | ||
| - GetSDLConnectionStatus - Provides status of connection to SDL | ||
|
|
||
| Mobile application should provide next information as main part of response to GetDeviceInfo request: |
There was a problem hiding this comment.
| Mobile application should provide next information as main part of response to GetDeviceInfo request: | |
| Mobile application should provide next information as main part of the response to `GetDeviceInfo` request: |
There was a problem hiding this comment.
@AKalinich-Luxoft Updated (see ae31abb)
| - GetSDLConnectionStatus - Provides status of connection to SDL | ||
|
|
||
| Mobile application should provide next information as main part of response to GetDeviceInfo request: | ||
| - Operating system |
There was a problem hiding this comment.
@aderiabin Why do we need OS info? I believe we would have unified script behavior for "Windows", "Android", "Linux", "LOLKEK"
There was a problem hiding this comment.
@AKalinich-Luxoft As far as I know the same type of transport (USB for example) has different handling on SDL side related of OS type of mobile side (AOA for Android for example). That is why script can request device with specific transport AND operating system to run test.
|
|
||
| Mobile application should provide next information as main part of response to GetDeviceInfo request: | ||
| - Operating system | ||
| - MAC address |
There was a problem hiding this comment.
@aderiabin I believe MAC address also should be an array OR moved into an array of available transports like a sub param because each transport chipset of the device may have its own MAC address so it's not a unique characteristic of the phone itself. For example, you can use your phone name (Settings -> About -> Device name) if you need some unique attribute for sorting.
There was a problem hiding this comment.
@AKalinich-Luxoft Agree. In additional to it, Android removes programmatic access to the device’s local hardware identifier (starting from Android 6.0). It would be work only for old devices.
doc
There was a problem hiding this comment.
@AKalinich-Luxoft, @YaroslavLutsenko Parameter MAC address has been removed. Parameter Array of transport` has been extended by transport specific information
(see 36b2cdb)
| Mobile application should provide next information as main part of response to GetDeviceInfo request: | ||
| - Operating system | ||
| - MAC address | ||
| - Array of transports available to connect to SDL |
There was a problem hiding this comment.
@aderiabin suggest describing in parenthesis what are the elements of the array are. Is that just a transport name or another structure? What should it contain?
There was a problem hiding this comment.
@AKalinich-Luxoft I have added such information. (see ae31abb)
But I think these are details of implementation and further adding of details to API lead to full API specification. I would like to leave it not specified in proposal.
There was a problem hiding this comment.
@AKalinich-Luxoft Information related to implementation details has been removed. (see 36b2cdb)
| - DisconnectFromSDL - Disconnects from SDL | ||
| - GetSDLConnectionStatus - Provides status of connection to SDL | ||
|
|
||
| Mobile application should provide next information as main part of response to GetDeviceInfo request: |
There was a problem hiding this comment.
@aderiabin probably make sense to mention that all parameters are mandatory OR mention if some of them are optional
There was a problem hiding this comment.
@AKalinich-Luxoft Added (see ae31abb)
dboltovskyi
changed the title
Current revision of the proposal is improving and specifying the solution accepted in the original proposal.
Main idea of introduced solution is to develop specifically Android mobile application that would use HTTP connection with REST protocol for control communication with ATF using API and would use TCP connection for raw data transfering bettween ATF and SDL.
This approach would provide the following benefits: