Fix keyboard behavior according to proposal #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. USER_CHOICE_INPUT_KEY_MASK will change input masking to true by default (was false) 2. Send OnKeyboardInput notifications for all masking modes, but only in case if it was actually changed
AKalinich-Luxoft
added a commit
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for 0238 proposal
This PR is ready for review.
Testing Plan
Will be tested manually
Summary
USER_CHOICE_INPUT_KEY_MASKwill change input masking to true by default (was false)OnKeyboardInputnotifications for all masking modes, but only afterSetGlobalPropertiesand clicking mask/unmask buttonCLA