Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL-0238 update per proposal revision #13

Conversation

KhrystynaDubovyk
Copy link

No description provided.

@KhrystynaDubovyk KhrystynaDubovyk requested review from dboltovskyi and removed request for dboltovskyi February 9, 2021 08:00
@@ -18,13 +18,13 @@ Purpose
* `menuName` and `templateTitle` should be included, if they are visible on HMI.
* `mainField1-4`, `statusBar` and `mediaTrack` should not be included if OEM implemented the `WEB_VIEW` template without these text fields.
* `availabletemplates`, `buttonCapabilities` and `imageTypeSupported` should reflect the general capabilities of the window/system.
5. HMI may send `KeyboardCapabilities` within OnSystemCapabilityUpdated notification which may include `maskInputCharactersSupported`, `supportedKeyboardLayouts` and `configurableKeys` parameters.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no separate configurableKeys param now, after revision it's a part of supportedKeyboards struct.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, updated in 7bf061d


!!! NOTE

1. Template `WEB_VIEW` is only allowed for the WebEngine applications with `AppHMIType`=`WEB_VIEW`.

2. In case HMI sends OnSystemCapabilityUpdated notification with `KeyboardCapabilities`, `supportedKeyboardLayouts` and without information about `numConfigurableKeys`, SDL would provide `KeyboardCapabilities` to app with `numConfigurableKeys` set to zero.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no case when it may be info about supportedKeyboards, but no info about numConfigurableKeys, because now numConfigurableKeys and keyboardLayout are mandatory fields of KeyboardLayoutCapability struct (supportedKeyboards).

That's why if we have some info about supported layouts, we will also have info about corresponding numKeys. So now not SDL, but HMI would provide KeyboardCapabilities to app with numConfigurableKeys set to zero.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ychernysheva, thanks.
I guess this point is worth removing. Since SDL would have to perform its regular function, i.e. transferring what was received from HMI to an app.
What would you say?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in b1deb58

@KhrystynaDubovyk KhrystynaDubovyk changed the title SDL-02338 update per proposal revision SDL-0238 update per proposal revision Feb 9, 2021
@KhrystynaDubovyk KhrystynaDubovyk merged commit 0149963 into feature/sdl_0238_keyboard_enhancements Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants