Fix: error handling #160
Merged
Fix: error handling #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
till
force-pushed
the
error-msg
branch
7 times, most recently
from
3e1380e
to
6ba677d
Compare
Display the actual error message returned from the collector. Test for the correct (lower level) error before using it. For: #159
- remove the mess with wait groups that I did - spin off dns client/resolver part - pass Target struct around (instead of string) - add a couple tests - add a mock dns server for tests
- uses an action to start the service - puts all assertions into wait-for - set explicit timeouts - puts everything in one job (to avoid upload/download)
Chore: please the linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the actual error message returned from the collector.
Test for the correct (lower level) error before using it.
For: #159