Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing error in shotgun surgery comparison to Solution Sprawl #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing error in shotgun surgery comparison to Solution Sprawl #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/smells/shotgun-surgery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ history:

Similar to [Divergent Change](./divergent-change.md), but with a broader spectrum, the smell symptom of the _Shotgun Surgery_ code is detected by the unnecessary requirement of changing multiple different classes to introduce a single modification. Things like that can happen with the failure to use the correct design pattern for the given system. This expansion of functionality can lead to an easy miss (and thus introduce a bug) if these small changes are all over the place and they are hard to find. Most likely, [too many classes](./oddball-solution.md) solve a simple problem.

Joshua Kerievsky noted this smell as _Solution Sprawl_ [[1](#sources)]. Monteiro stated that the tiny difference between these two comes from how they are sensed. In the [Divergent Change](./divergent-change.md), one becomes aware of the smell while making the changes, and in the _Solution Sprawl_, one is aware by observing the issue. [[2](#sources)]
Joshua Kerievsky noted this smell as _Solution Sprawl_ [[1](#sources)]. Monteiro stated that the tiny difference between these two comes from how they are sensed. In the _Shotgun Surgery_, one becomes aware of the smell while making the changes, and in the _Solution Sprawl_, one is aware by observing the issue. [[2](#sources)]

### Causation

Expand Down