This repository has been archived by the owner on Dec 25, 2023. It is now read-only.
Show the state of public_photos_hidden #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
d7415
reviewed
Feb 19, 2021
| if (lychee.downloadable) { | ||
| $('.basicModal .choice input[name="downloadable"]').prop("checked", true); | ||
| } | ||
| // Photos shared individually are always hidden. | ||
| $('.basicModal .choice input[name="hidden"]').prop("checked", true); |
There was a problem hiding this comment.
Good optimisation! I'm unclear why that was there twice.
There was a problem hiding this comment.
I'm guessing it was a copy-paste error when share_button_visible was added.
ildyria
approved these changes
Feb 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor front end companion to LycheeOrg/Lychee#932. It doesn't add any new functionality; it just makes sure that the visibility dialog for photos correctly reflects the setting of the new
public_photos_hiddenconfig.