Generated album UIDs should not have a hyphen at the end of the UID

[jessienab]

Enhancement

Example:
photos.localhost/gallery/N4tkibPPuy2bLfsXcBRwMq10-

On many Android devices, this URL is not hyperlinked properly as the trailing hyphen is not considered part of the URL. One such case is with Signal Android:

signalapp/Signal-Android#11310
signalapp/Signal-Android#12288
signalapp/Signal-Android#13049

However on Signal's side it seems to be a Won't Fix for them to not use linkifier, but ignoring that... it would probably be ideal otherwise.

Just a thought :)

[ildyria]

They are not that common (15/795 on my DB).
Feel free to propose a fix here:
https://github.com/LycheeOrg/Lychee/blob/master/app/Models/Extensions/HasRandomIDAndLegacyTimeBasedID.php#L154

[d7415]

Example:
photos.localhost/gallery/N4tkibPPuy2bLfsXcBRwMq10-

FWIW that URL works in Signal. The first issue you posted (the only one relating to -) is marked fixed.

[jessienab]

Example:
photos.localhost/gallery/N4tkibPPuy2bLfsXcBRwMq10-

FWIW that URL works in Signal. The first issue you posted (the only one relating to -) is marked fixed.

Just curious, is that Signal Android, iOS, or Desktop; and which version? As some friends are still experiencing the lack of hyphen being part of the hyperlink, with Signal Android. It would be helpful to further report to Signal :)

[ildyria]

Just tested on my Samsung Galaxy & Signal 7.17.6, can confirm it works as expected. :|

[d7415]

Android here too. May be able to test ios tomorrow. (Although as your issue links were all android I'd guess your friends are too?)

[jessienab]

Just tested on my Samsung Galaxy & Signal 7.17.6, can confirm it works as expected. :|

Android here too. May be able to test ios tomorrow. (Although as your issue links were all android I'd guess your friends are too?)

Yes, my friends device was Android... it really seems very device and software build specific then 😟

See my reply further down. Thank you both for testing!

[jessienab]

Hello, I opened the following PR: #2554

based on input from an associate of mine who is a dedicated PHP developer. Since I am not, and since I have not provided a test / confirmed this doesn't break anything, I am fine if the PR/change is not accepted. Realistically this is the extent of my input on this issue, which I fully recognize is absolutely a rare and odd edge case...

It also seems per other commenters that this is VERY device specific as various other Android devices appear to not have issues parsing the URL with a hyphen at the end...

Therefore, if desired, this discussion and the PR may be closed if needed, as this could very well be all for naught.

Regardless, thank you very much all for the input and testing!

[ildyria]

I fixed your PR :)
Check it out.