Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] cli sync from from server with option to delete #1056

Closed
tomergam opened this issue Jul 11, 2021 · 2 comments · Fixed by #1086
Closed

[Enhancement] cli sync from from server with option to delete #1056

tomergam opened this issue Jul 11, 2021 · 2 comments · Fixed by #1086
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tomergam
Copy link

I am using the command: php artisan lychee:sync
part of the cron job it will run every day, the android phone will push the photos to a directory in the server,
but there is no option to "delete original" as in the GUI

maybe there is different API call, or it not exists for the CLI

@kamil4 kamil4 added enhancement New feature or request good first issue Good for newcomers labels Jul 12, 2021
@kamil4
Copy link
Contributor

kamil4 commented Jul 12, 2021

Indeed. It appears to be deliberately coded that way:

$exec->delete_imported = false; // we want to sync -> do not delete imported files

I guess the lychee:sync command was meant to be limited-utility (just to keep lychee in sync with an external directory) but I agree with you that it seems unnecessarily limiting...

@d7415
Copy link
Contributor

d7415 commented Jul 12, 2021

Agreed. I see no reason not to expose that (or even some of the other options) to the command line.

ildyria pushed a commit that referenced this issue Aug 17, 2021
fixes: #1056

* Update Sync.php
* Improve CLI arguments and their evaluation.

Co-authored-by: Matthias Nagel <matthias.h.nagel@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants