Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Lychee-front #273. #1108

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Fixes Lychee-front #273. #1108

merged 3 commits into from
Sep 29, 2021

Conversation

nagmat84
Copy link
Collaborator

See PR #274 of Lychee-front.

This PR does not only include the new commit of the front-end, but also fixes the typography at the back-end.

@codecov
Copy link

codecov bot commented Sep 27, 2021 •
edited
Loading

Codecov Report

Merging #1108 (7790521) into master (d9cb6ad) will decrease coverage by 0.95%.
The diff coverage is 100.00%.

ildyria
ildyria approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need sync of Lychee-front and ready to merge.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nagmat84 nagmat84 merged commit 3d46ab0 into master Sep 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_frontend_273 branch September 29, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nagmat84 @ildyria