Make necessary configs available to the front end #1128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1127
As it turns out, config variables with
confidentiality
set to2
aren't actually available to the front end as part ofSession::init
. The server distinguishes only between public and admin; there is no separate provision for logged in users.This patch follows this model and changes the confidentiality of three variables that should be exposed to logged in users (
editor_enabled
,upload_processing_limit
, andpublic_photos_hidden
) to0
.An alternative implementation would be for
Session::init
to treat logged in users as a separate category. Feedback welcome...