Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1146 #1147

Merged
merged 2 commits into from
Nov 20, 2021
Merged

Fixes #1146 #1147

merged 2 commits into from
Nov 20, 2021

Conversation

nagmat84
Copy link
Collaborator

Should probably also be included in the next release of minor bug fixes.

@nagmat84 nagmat84 requested a review from ildyria November 20, 2021 15:55
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #1147 (8af3401) into master (f29922d) will decrease coverage by 1.37%.
The diff coverage is n/a.

@ildyria
Copy link
Member

ildyria commented Nov 20, 2021 via email

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nagmat84
Copy link
Collaborator Author

I would also add in the .gitHub/workflows/actions (Dist & Dev) the line php artisan optimize just so that we also get the test from it

Done.

@ildyria ildyria merged commit 5442b8e into master Nov 20, 2021
@ildyria ildyria deleted the fix-iss-1146 branch November 20, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants