Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1208 #1212

Merged
merged 5 commits into from
Feb 7, 2022
Merged

Fixes #1208 #1212

merged 5 commits into from
Feb 7, 2022

Conversation

nagmat84
Copy link
Collaborator

@nagmat84 nagmat84 commented Feb 1, 2022

Fixes #1208 and syncs @kamil4's latest changes to the front-end while we are on it.

@nagmat84 nagmat84 requested a review from ildyria February 1, 2022 18:44
@codecov
Copy link

codecov bot commented Feb 1, 2022 •
edited
Loading

Codecov Report

Merging #1212 (87002a9) into master (8c6b200) will decrease coverage by 0.94%.
The diff coverage is n/a.

@nagmat84 nagmat84 requested a review from kamil4 February 1, 2022 18:44
ildyria
ildyria approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kamil4
kamil4 approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@kamil4 kamil4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but looks sane.

app/Console/Commands/Takedate.php Outdated Show resolved Hide resolved
app/Console/Commands/Takedate.php Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nagmat84 nagmat84 merged commit 373382b into master Feb 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the fixes-1208 branch February 7, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

@kamil4 kamil4 kamil4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete the update of 'app/Console/Commands/Takedate.php' to the refactored timestamps
3 participants
@nagmat84 @ildyria @kamil4