Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Belated sync of frontend for PR #1239 #1245

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

nagmat84
Copy link
Collaborator

I merged PR #1239 by @Chostakovitch some days ago, but did not notice that is it was not in sync with the associated PR to the frontend. So the current master is in an unusable state because the backend code and the frontend are out-of-sync. This PR fixes the problem.

Shame on me that I did not check that back then and did not follow our process, merge frontend first, merge new master of frontend into PR of backend, merge backend. :-(

@nagmat84 nagmat84 requested a review from ildyria March 24, 2022 19:08
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #1245 (80d1bdf) into master (05f21d4) will decrease coverage by 0.93%.
The diff coverage is n/a.

Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nagmat84 nagmat84 merged commit e150930 into master Mar 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the belated_sync_of_frontend branch March 24, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants